Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsers.elm:111: Parsing Float Strings with additional... #3

Open
0pdd opened this issue Dec 6, 2019 · 0 comments
Open

Parsers.elm:111: Parsing Float Strings with additional... #3

0pdd opened this issue Dec 6, 2019 · 0 comments

Comments

@0pdd
Copy link

0pdd commented Dec 6, 2019

The puzzle 1-32b77974 from #1 has to be resolved:

@todo #1 Parsing Float Strings with additional thousands separators is not supported. The parsing will fail in this scenario. Consider using `Parser.loop` and `Parser.oneOf`. Also I think it should test if the created number is supported by the js runtime. There is an elm lib to do this. Maybe it is easy to implement it by yourself, and the lib is not needed. Also, should mixed separator 'types' be possible ? or could it cause a performance issue ? Right now it supports mixed decimal separators using `Parser.oneOf`

The puzzle was created by Robin Gruenke on 06-Dec-19.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant