Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18.2. Could not pass event CraftDetectEvent to StructureBoxes v3.4 #27

Open
TomLewis opened this issue Apr 14, 2022 · 10 comments
Open
Labels
bug Something isn't working

Comments

@TomLewis
Copy link

Describe the bug
I don't think this has been updated to work with Movecraft-8.0.0-a.7.jar
This is just a snippet of the errors https://gist.github.com/TomLewis/dc874c2f999df209cb23c5aa266f0ad4

To Reproduce
Steps to reproduce the behavior:

  1. Install StructureBoxes v3.4 & Movecraft-8.0.0-a.7.jar
  2. Errors.

Expected behavior
Not to spam errors

Environment (please complete the following information):

  • OS: Debian 11
  • Minecraft version 1.18.2
  • Server software PurPur
@TomLewis TomLewis added the bug Something isn't working label Apr 14, 2022
@TomLewis
Copy link
Author

@eirikh1996 @TylerS1066 Any chance in getting this resolved? Thank you!

@TylerS1066
Copy link
Contributor

TylerS1066 commented May 17, 2022

AP has ended up forking this plugin and modifying the internals heavily to only suit our needs due to the lack of support (this, #24, etc).

We host the source and CI on GitHub but provide no support for it.

@TomLewis
Copy link
Author

Thanks @TylerS1066 is there a list of breaking changes or feature changes anywhere on that repo to see if I could use it?

@TylerS1066
Copy link
Contributor

We've removed a ton of the supported platforms and integrations in our version of StructureBoxes. It now only supports Movecraft 8, WorldEdit/WorldGuard 7.x and Spigot derivatives on 1.14.4+.

Most of the work has been on bringing it in line with Movecraft 8's latest API changes, removing complexity (like all those other supported platforms & plugins), and cleaning up unneeded code. I believe all the functionality (w.r.t. the supported plugins) is still there, but if you relied on integration with one of the removed plugins, then it will not work for you.

@TomLewis
Copy link
Author

I should meet that spec, im all updated for plugins on 1.18.2.
Sounds like a good place to be, at a simplier codebase thats eaiser to maintain and update for future releases.

I only use it for Ships currently, but I did request a random schematic picker that was added, is that still in?

@TylerS1066
Copy link
Contributor

but I did request a random schematic picker that was added, is that still in?

I'm not sure, can you describe the feature a bit better?

@TomLewis
Copy link
Author

I'm not sure, can you describe the feature a bit better?

https://dev.bukkit.org/projects/structure-boxes/files/3126891

Added the ability to put multiple schematics into one structure box, spawning a random structure on placement

    Each schematic must have the same ID, followed by an underscore, _, and an integer value. The lore identifier for this type of structure boxes will have _# on the end
    For example: House_1, House_2, House_3. A structure box spawning a random structure will then have House_# as its ID

@TylerS1066
Copy link
Contributor

Added the ability to put multiple schematics into one structure box, spawning a random structure on placement

    Each schematic must have the same ID, followed by an underscore, _, and an integer value. The lore identifier for this type of structure boxes will have _# on the end
    For example: House_1, House_2, House_3. A structure box spawning a random structure will then have House_# as its ID

It looks like it is still in the plugin: https://github.com/APDevTeam/StructureBoxes/blob/8af296259acfd2a2a2a570af26e2cbcc99404536/src/main/java/io/github/eirikh1996/structureboxes/listener/BlockListener.java#L86

I've not tested it (or was aware of it existing), but I don't see why it would be broken.

@TomLewis
Copy link
Author

Would you be happy to upload releases of this version of StructureBoxes into github?

@TylerS1066
Copy link
Contributor

Would you be happy to upload releases of this version of StructureBoxes into github?

I created a tag & release for the current version AP is running: https://github.com/APDevTeam/StructureBoxes/releases/tag/4.0.0-a.1

I think in the future I'll probably avoid doing releases and instead you can just download the plugin from the dev builds attached to the GitHub actions CI unless I get a lot of interest in the plugin.

For example, the same jar in that release can be found in the StructureBoxes_Dev-Build zip file (only available while logged into GitHub) of the actions run which you can access by clicking the little icon next to the commit ID on the front page:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants