fix: missing localized strings

closes #450
ejbills · Jan 9, 2025 · c7432ce · c7432ce
1 parent 78b5745
commit c7432ce
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/DockDoor/Components/EnabledActionRowView.swift b/DockDoor/Components/EnabledActionRowView.swift
@@ -7,8 +7,8 @@ struct EnabledActionRowView: View {
     var iconName: String
     var action: (() -> Void)?
     var disableShine: Bool = false
-    var buttonText: String = "Open Settings"
-    var statusText: String = "Granted"
+    var buttonText: String = .init(localized: "Open Settings")
+    var statusText: String = .init(localized: "Granted")
     var customStatusView: AnyView?
     var hideStatus: Bool = false
 
@@ -34,7 +34,7 @@ struct EnabledActionRowView: View {
                 } else {
                     VStack(alignment: .trailing, spacing: 4) {
                         HStack {
-                            Text(isGranted ? statusText : "Not \(statusText.lowercased())")
+                            Text(isGranted ? statusText : String(localized: "Not \(statusText.lowercased())"))
                                 .font(.caption)
                                 .foregroundStyle(.secondary)
                             Image(systemName: isGranted ? "checkmark.circle.fill" : "xmark.circle.fill")

diff --git a/DockDoor/Components/StyledGroupBox.swift b/DockDoor/Components/StyledGroupBox.swift
@@ -1,10 +1,16 @@
 import SwiftUI
 
 struct StyledGroupBox<Content: View>: View {
-    let label: String
+    let label: LocalizedStringKey
     let content: Content
 
-    init(label: String, @ViewBuilder content: () -> Content) {
+    init(label: LocalizedStringKey, @ViewBuilder content: () -> Content) {
+        self.label = label
+        self.content = content()
+    }
+
+    // Add convenience init for string literals
+    init(_ label: LocalizedStringKey, @ViewBuilder content: () -> Content) {
         self.label = label
         self.content = content()
     }

diff --git a/DockDoor/Localizable.xcstrings b/DockDoor/Localizable.xcstrings
@@ -9899,7 +9899,6 @@
       }
     },
     "Colors" : {
-      "extractionState" : "stale",
       "localizations" : {
         "af" : {
           "stringUnit" : {
@@ -12565,6 +12564,9 @@
           }
         }
       }
+    },
+    "Dock Previews" : {
+
     },
     "Dock Previews & Window Switcher" : {
       "comment" : "Preview window title display condition option",
@@ -17900,7 +17902,6 @@
       }
     },
     "Granted" : {
-      "extractionState" : "stale",
       "localizations" : {
         "af" : {
           "stringUnit" : {
@@ -25326,6 +25327,9 @@
           }
         }
       }
+    },
+    "Not %@" : {
+
     },
     "Not granted" : {
       "extractionState" : "stale",
@@ -42089,6 +42093,9 @@
           }
         }
       }
+    },
+    "Traffic Light Buttons" : {
+
     },
     "Traffic Light Buttons Position" : {
       "extractionState" : "stale",
@@ -48564,6 +48571,9 @@
           }
         }
       }
+    },
+    "Window Preview Layout" : {
+
     },
     "Window Preview Layout Limits" : {
       "extractionState" : "stale",