feat: make traffic lights button symbols colored like macOS buttons #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShlomoCode
force-pushed
the
traffic-lights-in-light-theme
branch
from
67bf062 to
b7f4d13
Compare
ShlomoCode
changed the title
ShlomoCode
changed the title
ShlomoCode
changed the title
ShlomoCode
changed the title
ShlomoCode
changed the title
ShlomoCode
changed the title
ShlomoCode
force-pushed
the
traffic-lights-in-light-theme
branch
from
b7f4d13 to
06b1430
Compare
ejbills
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traffic light buttons mimic those of macOS, and macOS never changes the button's icon color:
CleanShot.2024-07-10.at.16.28.12.mp4
I checked the colors of the macOS buttons with https://github.com/sindresorhus/System-Color-Picker and set them for our buttons. For the quit button I just used dark purple:
closes #132