chore(format): preserve unused arguments #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve parameter names for better code readability and potential future use. https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#unusedarguments
To support Shorthand if let/guard let (since 5.7) and more
ShlomoCode
force-pushed
the
preserve-unused-arguments
branch
from
af0dd23 to
a1ccc7e
Compare
ShlomoCode
changed the title
|
@ejbills Can you take a look? |
I posted a comment |
|
I don't see... Please check that it appears to you in incognito mode |
ejbills
reviewed
Aug 13, 2024
There was a problem hiding this comment.
This is an automatic removal of SwiftFormat following the fact that I jumped the swift version to 5.10, because implicit return is supported starting from swift 5.9
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0380-if-switch-expressions.md
We can disable the rule, if you want.
There was a problem hiding this comment.
No, was just curious. Looks good then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Preserve parameter names for better code readability and potential future use.
https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#unusedarguments
Also, bump the swift version to the latest stable version, and enable Dead Code Stripping (recommended by Xcode).
Related issue number(s) and link(s)
No
Checklist before requesting a review
Core Functionality Changes
No