-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quoted text in comments not showing up properly #35
Comments
Weird because for me Block Quotes work properly. In testing it myself with comments from my own account and adding multiple quotes, they all appear to work properly. None are left out. Other formattings don't work properly though (Spoiler, Strikethrough, etc). |
Hmm that’s interesting. I came across this and the block quotes show up fine: https://www.reddit.com/r/pics/comments/1bdord8/paul_alexander_78_dies_after_being_in_an_iron/ However, visiting my prior example, they still don’t appear as expected. Please take a look at this one on your end and see how it appears: https://www.reddit.com/r/pcmasterrace/comments/1bd41mm/you_can_now_officially_uninstall_microsoft_edge/ Maybe it’s dependent on how the quote was submitted? Either bc of different apps or the glitchy Reddit site itself (I recall having my clipboard item being auto embedded into replies as quotes on the Reddit site. Could this be a cause)? I should have saved the other links |
Oops. Didn’t mean to close the issue. Great that the other bugs were found though |
Yeah, that second link even on my end doesn't appear as expected. I'm very confused what the issue is. Even testing different quote styles myself submitted via Old and New Reddit, plus various Reddit apps, it all shows up fine. We'll need the devs input on that. I'm just a fan of the app that likes to help out where I can. Artemis piggybacks off old.Reddit though, so keep that in mind. Whatever has been implemented for New Reddit wouldn't work. |
Hmm, I will take a deeper look into this. Converting HTML into markdown is wonky, and sometimes has weird inconsistencies like this. It's possible "quotes" are made up of varying HTML elements, when currently the code only converts a specific type of HTML block to a markdown quote. Thanks for reporting |
Edit: this may to be affecting other text formattings as well, at least I’ve come across a strikethrough appearing as normal text. Included ss of it below. I also noticed that the bullets in the same comment weren’t respected either
The first block of quoted text will show up as unquoted text. Any subsequent blocks, if any, show up correctly. See attached images for examples
The text was updated successfully, but these errors were encountered: