Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flags #13

Open
ejv2 opened this issue Aug 8, 2024 · 2 comments
Open

Add command line flags #13

ejv2 opened this issue Aug 8, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ejv2
Copy link
Owner

ejv2 commented Aug 8, 2024

Currently, podbit relies upon the newsboat config and its format to parse some important options. This is flimsy and breaks very easily. This also breaks the ability to add custom directory structures using the newsboat's template substitution stuff (%h for example).

I suggest that we add a new config file in {XDG_CONFIG_HOME}/podbit/config which contains these options with a similar config format to newsboat. We can then add a few more options to configure too. The db file could also be moved to this location, as I feel that makes more sense than being in the data path (while keeping backward compatibility if needed).

Possible new config keys

  • downloads-dir - works as currently intended but is only the base directory into which downloads are placed. The paths passed from newsboat are still used to find the download location
  • delete-played-files - copied from the podboat configuration
  • ytdl-flags - custom flags passed to youtube-dl or yt-dlp
  • clean-queue - dequeue items after they have been listened to and have expired (i.e remove from the queue file). For people like me with 10M queue files
@ejv2 ejv2 added the enhancement New feature or request label Aug 8, 2024
@ejv2 ejv2 added this to the Podbit v3.0 milestone Aug 8, 2024
@ejv2 ejv2 self-assigned this Aug 8, 2024
@ejv2 ejv2 modified the milestones: Podbit v3.0, Podbit v4.0 Aug 8, 2024
@ejv2
Copy link
Owner Author

ejv2 commented Aug 12, 2024

I think rather than a config file I will be using command line flags. These are easier to use etc.

If users want to permanently configure the program, they can use a script or an alias to pass the required flags.

@ejv2 ejv2 changed the title Add separate podbit config file Add command line flags Aug 12, 2024
@ejv2
Copy link
Owner Author

ejv2 commented Aug 12, 2024

Also, I am going to do away entirely with the idea of a "cache directory" and just load downloads from the path specified in the queue file. This will give the user more flexibility with downloads and also remove the complexity of having to detect it and/or walk through directories recursively when we begin to support the string formatting stuff from newsboat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant