Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Exclude test files from eslint max-line rule. #43

Open
maelaubert56 opened this issue Dec 2, 2024 · 0 comments
Open

[BUG]: Exclude test files from eslint max-line rule. #43

maelaubert56 opened this issue Dec 2, 2024 · 0 comments
Assignees
@helabenkhalfallah
Labels
bug Something isn't working
Milestone
Vitality 1.1

Comments

@maelaubert56
Copy link
Member

🐛 Description

Test functions describe() can contain lots of lines, so we should disable the eslint max-line rule for these functions.

For now, the error is bypassed by using /* eslint-disable max-lines-per-function */ in the relevant files like in PassportUtils-test.ts

📸 Screenshots

Screenshot 2024-12-02 at 17 40 48
@maelaubert56 maelaubert56 added the bug Something isn't working label Dec 2, 2024
@helabenkhalfallah helabenkhalfallah self-assigned this Dec 18, 2024
@helabenkhalfallah helabenkhalfallah added this to the Vitality 1.1 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helabenkhalfallah helabenkhalfallah

Labels
bug Something isn't working
Projects
None yet
Milestone
Vitality 1.1
Development

No branches or pull requests
2 participants
@helabenkhalfallah @maelaubert56