Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Apps are filtered in BFF instead of the DB query. #48

Open
2 of 3 tasks
maelaubert56 opened this issue Dec 16, 2024 · 0 comments · May be fixed by #67
Open
2 of 3 tasks

[FIX]: Apps are filtered in BFF instead of the DB query. #48

maelaubert56 opened this issue Dec 16, 2024 · 0 comments · May be fixed by #67
Assignees
@maelaubert56
Labels
bug Something isn't working
Milestone
Vitality 2.0

Comments

@maelaubert56
Copy link
Member

maelaubert56 commented Dec 16, 2024 •
edited
Loading

🐛 Description

  • Need to fix the typing coverage (can be seen using ts-coverage)

  • There is a duplication of the getApplicationList query.

  • The applications access is restricted depending on the user. For now, the filtering is done in the BFF which is not optimised. We should do it in the query to the database.
@maelaubert56 maelaubert56 added the bug Something isn't working label Dec 16, 2024
@maelaubert56 maelaubert56 self-assigned this Dec 16, 2024
@helabenkhalfallah helabenkhalfallah added this to the Vitality 2.0 milestone Dec 24, 2024
@maelaubert56 maelaubert56 linked a pull request Dec 24, 2024 that will close this issue
[FIX]: moved filtering of apps and fix duplicates #67
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maelaubert56 maelaubert56

Labels
bug Something isn't working
Projects
None yet
Milestone
Vitality 2.0
Development

Successfully merging a pull request may close this issue.

[FIX]: moved filtering of apps and fix duplicates ekino/v6y
2 participants
@helabenkhalfallah @maelaubert56