From 1155063784fc36bfc494f691270d0c3331657739 Mon Sep 17 00:00:00 2001 From: Steffen Windoffer Date: Mon, 22 May 2023 13:10:00 +0200 Subject: [PATCH 1/3] port Add ready plugin to CoreDNS and use health.lameduck for a safer shutdown to 1.25 and 1.26 --- pkg/addons/default/assets/coredns-1.25.json | 6 +++--- pkg/addons/default/assets/coredns-1.26.json | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/addons/default/assets/coredns-1.25.json b/pkg/addons/default/assets/coredns-1.25.json index e699a9e45d..275418780b 100644 --- a/pkg/addons/default/assets/coredns-1.25.json +++ b/pkg/addons/default/assets/coredns-1.25.json @@ -61,7 +61,7 @@ { "apiVersion": "v1", "data": { - "Corefile": ".:53 {\n errors\n health\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" + "Corefile": ".:53 {\n errors\n health {\n lameduck 5s\n }\n ready\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" }, "kind": "ConfigMap", "metadata": { @@ -205,8 +205,8 @@ "readinessProbe": { "failureThreshold": 3, "httpGet": { - "path": "/health", - "port": 8080, + "path": "/ready", + "port": 8181, "scheme": "HTTP" }, "periodSeconds": 10, diff --git a/pkg/addons/default/assets/coredns-1.26.json b/pkg/addons/default/assets/coredns-1.26.json index e699a9e45d..b6b7be6c35 100644 --- a/pkg/addons/default/assets/coredns-1.26.json +++ b/pkg/addons/default/assets/coredns-1.26.json @@ -61,7 +61,7 @@ { "apiVersion": "v1", "data": { - "Corefile": ".:53 {\n errors\n health\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" + "Corefile": ".:53 {\n errors\n health {\n lameduck 5s\n }\n ready\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" }, "kind": "ConfigMap", "metadata": { @@ -175,8 +175,8 @@ "livenessProbe": { "failureThreshold": 5, "httpGet": { - "path": "/health", - "port": 8080, + "path": "/ready", + "port": 8181, "scheme": "HTTP" }, "initialDelaySeconds": 60, From 4ec6faec7d0601400c6a3cbd756739025056ac6c Mon Sep 17 00:00:00 2001 From: Steffen Windoffer Date: Wed, 24 May 2023 15:07:32 +0200 Subject: [PATCH 2/3] port Add ready plugin to CoreDNS and use health.lameduck for a safer shutdown to 1.25 and 1.26 --- pkg/addons/default/testdata/sample-1.22.json | 6 +++--- pkg/addons/default/testdata/sample-1.25.json | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/addons/default/testdata/sample-1.22.json b/pkg/addons/default/testdata/sample-1.22.json index 3701a98a43..af3ef79b29 100644 --- a/pkg/addons/default/testdata/sample-1.22.json +++ b/pkg/addons/default/testdata/sample-1.22.json @@ -225,7 +225,7 @@ { "apiVersion": "v1", "data": { - "Corefile": ".:53 {\n errors\n health\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n upstream\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" + "Corefile": ".:53 {\n errors\n health {\n lameduck 5s\n }\n ready\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n upstream\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" }, "kind": "ConfigMap", "metadata": { @@ -338,8 +338,8 @@ "livenessProbe": { "failureThreshold": 5, "httpGet": { - "path": "/health", - "port": 8080, + "path": "/ready", + "port": 8181, "scheme": "HTTP" }, "initialDelaySeconds": 60, diff --git a/pkg/addons/default/testdata/sample-1.25.json b/pkg/addons/default/testdata/sample-1.25.json index 13deeb14c5..e26b21db7d 100644 --- a/pkg/addons/default/testdata/sample-1.25.json +++ b/pkg/addons/default/testdata/sample-1.25.json @@ -247,7 +247,7 @@ { "apiVersion": "v1", "data": { - "Corefile": ".:53 {\n errors\n health\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" + "Corefile": ".:53 {\n errors\n health {\n lameduck 5s\n }\n ready\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" }, "kind": "ConfigMap", "metadata": { @@ -361,8 +361,8 @@ "livenessProbe": { "failureThreshold": 5, "httpGet": { - "path": "/health", - "port": 8080, + "path": "/ready", + "port": 8181, "scheme": "HTTP" }, "initialDelaySeconds": 60, From 786a1f0489d0e686d9b01563d3bbd7c0e0efc0ee Mon Sep 17 00:00:00 2001 From: Steffen Windoffer Date: Wed, 24 May 2023 15:12:06 +0200 Subject: [PATCH 3/3] port Add ready plugin to CoreDNS and use health.lameduck for a safer shutdown to 1.27 --- pkg/addons/default/assets/coredns-1.27.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/addons/default/assets/coredns-1.27.json b/pkg/addons/default/assets/coredns-1.27.json index 2a98e871e4..3ad8d820d7 100644 --- a/pkg/addons/default/assets/coredns-1.27.json +++ b/pkg/addons/default/assets/coredns-1.27.json @@ -61,7 +61,7 @@ { "apiVersion": "v1", "data": { - "Corefile": ".:53 {\n errors\n health\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" + "Corefile": ".:53 {\n errors\n health {\n lameduck 5s\n }\n ready\n kubernetes cluster.local in-addr.arpa ip6.arpa {\n pods insecure\n fallthrough in-addr.arpa ip6.arpa\n }\n prometheus :9153\n forward . /etc/resolv.conf\n cache 30\n loop\n reload\n loadbalance\n}\n" }, "kind": "ConfigMap", "metadata": { @@ -205,8 +205,8 @@ "readinessProbe": { "failureThreshold": 3, "httpGet": { - "path": "/health", - "port": 8080, + "path": "/ready", + "port": 8181, "scheme": "HTTP" }, "periodSeconds": 10,