Deprecated apiVersion used for MutatingWebhookConfiguration and CertificateSigningRequest

[nluckenbill]

Hello, when creating a new admission controller, eksctl prints out the following warnings:

warnings.go:67] certificates.k8s.io/v1beta1 CertificateSigningRequest is deprecated in v1.19+, unavailable in v1.22+; use certificates.k8s.io/v1 CertificateSigningRequest

warnings.go:67] admissionregistration.k8s.io/v1beta1 MutatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration

This can be reproduced following the instructions here:
https://docs.aws.amazon.com/eks/latest/userguide/windows-support.html#enable-windows-support

VERSIONS

Admin:~/environment $ eksctl version
0.53.0
Admin:~/environment $ kubectl version
Client Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.6-eks-49a6c0", GitCommit:"49a6c0bf091506e7bafcdb1b142351b69363355a", GitTreeState:"clean", BuildDate:"2020-12-23T22:13:28Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.8-eks-96780e", GitCommit:"96780e1b30acbf0a52c38b6030d7853e575bcdf3", GitTreeState:"clean", BuildDate:"2021-03-10T21:32:29Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

[cPu1]

Thanks for the heads-up, we'll work on this soon.

[Callisto13]

@cPu1 are you actively writing this at the moment? If not can you un-assign and throw it back into the pool?

[awsitcloudpro]

In addition to switching to the stable API versions, it will be best to stay away from the Legacy K8s signer, and instead use cert-manager or similar tool to issue the certificate for the admission webhook.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[Callisto13]

@cPu1 do you know if we are still blocked upstream on this?

[cPu1]

@cPu1 do you know if we are still blocked upstream on this?

We're blocked upstream on CertificateSigningRequest, but not on MutatingWebhookConfiguration. We should be able to migrate to admissionregistration.k8s.io/v1.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[cPu1]

We have a merged PR that we had to revert temporarily, that will remove the need for installing the VPC controller in order to run Windows workloads, making this issue obsolete. We'll close this issue when we re-merge that PR back.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[cPu1]

Not stale, this is blocked on AWS.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[Himangini]

We have a merged PR that we had to revert temporarily, that will remove the need for installing the VPC controller in order to run Windows workloads, making this issue obsolete. We'll close this issue when we re-merge that PR back.

@cPu1 The PR you mentioned is merged, can we close this issue, or is this still blocked upstream?

[cPu1]

This is obsoleted by #4338.