Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodegroup): new integration: spot ocean #6694

Closed
IdanShohamNetApp opened this issue Jun 14, 2023 · 24 comments
Closed

feat(nodegroup): new integration: spot ocean #6694

IdanShohamNetApp opened this issue Jun 14, 2023 · 24 comments
Labels
kind/feature New feature or request

Comments

@IdanShohamNetApp
Copy link

IdanShohamNetApp commented Jun 14, 2023

Why do you want this feature?

Similarly to the existing integration with kops instance groups, we'd like to integrate Ocean by Spot with eksctl.

What feature/behavior/change do you want?

Seamlessly integration of Ocean with unmanaged nodegroups, as part of a demand of AWS customers.

Pull request

#6731

Please check out our proposal documentation.

@IdanShohamNetApp IdanShohamNetApp added the kind/feature New feature or request label Jun 14, 2023
@github-actions
Copy link
Contributor

Hello IdanShohamNetApp 👋 Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@jslaughterSpot
Copy link

Along with the above proposal, I want to add some context and stress the demand we are seeing on this side.

Demand for an upstream integration has been increasing as users continue to utilize this tool and expect official, maintained and updated resources. I get this request from a variety of our users on a weekly basis and it's only growing.

In terms of support and maintenance:

Spot by Netapp pledges to fully maintain this integration.
This includes:

  • Monthly updates with new features
  • Code reviews and feature assessment from the direct EKSCTL community
  • Feature parity with our direct API and UI enabling EKSCTL all the latest features
  • Spot by Netapp fully managing Support and maintenance of this integration
    • Bug fixes directly from the EKSCTL community
    • Urgent 24/7 support available on our platform
    • Ensuring full compatibility with the newest versions of Kubernetes and EKS

@swharr
Copy link

swharr commented Jun 22, 2023

I would just like to echo that this feature being added would be helpful. I have several ocean clusters and would like to be able to use eksctl to manage them a bit tighter than having to bounce around between CLI management tools.

@rjmorse
Copy link

rjmorse commented Jun 22, 2023

At Ticketmaster we leverage Spot by NetApp via the current forked EKSCTL to manage our EKS clusters, and have been doing so for years. Over the last year I've seen management of the fork improve (more quickly and regularly rebase upstream changes to the fork as well as adding Spot API support for new Spot/NetApp features) and we would very much appreciate the ability to upstream this capability.

I have to acknowledge the previous attempt at #2364 and my hope is this is presented in a more suitable manner and possibly work together to progress this.

@rcohen650
Copy link

rcohen650 commented Jun 22, 2023

This would be an absolute game changing for our usage of eksctl

@camclay
Copy link

camclay commented Jun 22, 2023

Would greatly appreciate this work being upstreamed, as Kubernetes continues to rapidly develop, having tighter integration of the full EKSCTL with Spot by NetApp helps us to avoid version issues, ans maintain our fleet of EKS clusters in multiple regions.

@wlieberz
Copy link

I'd definitely like to see this upstreamed. I believe it would help reduce ecosystem fragmentation and provide a better experience for eksctl users.

@usmanakramb
Copy link

Would be great to have upstream support and streamline usage of eksctl

@Sconrad04
Copy link

I would definitely love to see this integration for all the reasons mentioned above.

@soubhik001
Copy link

We love managing kubernetes via cli and eksctl is too handy to create a cluster/node group. A direct integration to create an Ocean cluster/node group using eksctl would give us an effortless way to create and maintain unmanaged Kubernetes clusters through Ocean and save a lot of time. Really looking forward to see it getting upstreamed.

@ultgeek
Copy link

ultgeek commented Jun 22, 2023

This would be a very welcome addition to our use case.

@Shoobe13
Copy link

This integration would be a huge benefit for our usage of eksctl!

@G33kG1rl20
Copy link

I'd find this feature very useful especially since I'm already familiar with eksctl. Please add!

@JenniferFlanaganSpot
Copy link

I see a ton of value for our joint customers getting this upstreamed. Prioritize this :)

@kaugm
Copy link

kaugm commented Jun 22, 2023

Eksctl is a super useful tool, and this integration would be hugely beneficial for simplifying management of Ocean nodegroups as well. Please add!

@victorvianas
Copy link

Would love to see this integration working. One of the best ways to manage EKS clusters is by using CLI tools like eksctl, and having a daily usage tool working together with Spot by NetApp products will save a ton of DYI work for DevOps Engineers / SREs, etc. Can't agree more with the other users who commented on this thread.

@CrisNevares
Copy link

Would love to see this upstreamed!

@denishelena
Copy link

Hello everyone, we are working with eksctl to provision the Kubernetes cluster, and today have two possibilities, create a Cluster with Spotinst integration and without Spotinst integration. We have seen a bad experience working with two different implementations that are the same thing. It makes sense that Waveworks adds that possibility to the same project, considering that big companies already work with this implementation.

@jescarri
Copy link

Eksctl is a great tool for managing eks clusters, at Ticketmaster we run eks + spot.io, and we manage the clusters using the forked version of eksctl with the spot.io integration, over the years the quality of the integration has improved and support from spot.io on keeping the fork up to date has been great.

We would love to see the support for spot.io in Eksctl upstreamed.

@Himangini
Copy link
Collaborator

Dupe of #2364
Decision comment on the previous thread: #2364 (comment)

@mikestef9 There's a lot of interest from the community for this feature, can we reconsider the decision?

@swharr
Copy link

swharr commented Jul 12, 2023

Dupe of #2364 Decision comment on the previous thread: #2364 (comment)

@mikestef9 There's a lot of interest from the community for this feature, can we reconsider the decision?

I am wondering whats next to get this feature request reconsidered. I know that two years ago it was decided not to integrate, but as the traffic above shows there is a lot of desire to have this feature bolted in upstream

@mikestef9
Copy link
Collaborator

The stance has not changed since the original comment. However, since that comment, we have launched native EKS add-ons marketplace integration https://aws.amazon.com/blogs/aws/new-aws-marketplace-for-containers-now-supports-direct-deployment-to-amazon-eks-clusters/

Adding the Ocean controller to EKS add-ons Marketplace integration is best path forward here.

@mataneja
Copy link

@mikestef9 AWS MP for containers only solves for Ocean helm charts but offers "no" solution for managing Ocean via standard Infrastructure as Code primitives aka eksctl. Is there an alternate ability in the AWS MP to solve for eksctl?

@tanvp112
Copy link

Spot Ocean is a commercial product and not open source, right? Best to integrate with marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests