Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build without exceptions #804

Closed
elalish opened this issue May 9, 2024 · 3 comments
Closed

Build without exceptions #804

elalish opened this issue May 9, 2024 · 3 comments
Labels
bug Something isn't working
Milestone
v3.0

Comments

@elalish
Copy link
Owner

elalish commented May 9, 2024

We did a fair bit of work to ensure Manifold worked with exceptions disabled, but I'm concerned that may have been broken in the time since. First step is to make sure at least one of our CI builds is without exceptions. If that doesn't work, let's see how we can fix it. WDYT @pca006132?
@elalish elalish added the bug Something isn't working label May 9, 2024
@elalish
Copy link
Owner Author

elalish commented May 9, 2024

For reference: godotengine/godot#91748

@pca006132 pca006132 mentioned this issue Jun 8, 2024
Merged
@elalish elalish added this to the v3.0 milestone Jun 16, 2024
@fire
Copy link
Contributor

fire commented Jul 13, 2024

I am testing this in godotengine/godot#94321

@elalish
Copy link
Owner Author

elalish commented Jul 13, 2024

Thank you! We should have marked this as fixed by #833. Please re-open this if you find a problem.

@elalish elalish closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@fire @elalish