Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require IsOk to be DeserializeOwned #242

Open
KodrAus opened this issue Sep 27, 2017 · 0 comments
Open

Don't require IsOk to be DeserializeOwned #242

KodrAus opened this issue Sep 27, 2017 · 0 comments
Labels
change:breaking

Comments

@KodrAus
Copy link
Member

KodrAus commented Sep 27, 2017

Even though none of the types in elastic_responses borrow from the data (because you might want to call from_reader) we shouldn't limit IsOk to just owned responses because callers could write their own.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change:breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KodrAus