Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify request params building #372

Open
KodrAus opened this issue Jul 7, 2019 · 0 comments
Open

Simplify request params building #372

KodrAus opened this issue Jul 7, 2019 · 0 comments

Comments

@KodrAus
Copy link
Member

KodrAus commented Jul 7, 2019

Using captured fluent builders means we need to allocate for each call to _fluent, and means we need to impose Send + Sync constraints on the builder methods themselves. There are other footguns around APIs that issue multiple requests, like a bulk stream that may go on indefinitely. Since we don't rebuild the parameters we'll always issue those requests to the same node.

So we should just remove the fluent builder infrastructure and apply fluent methods to values inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants