Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ support for .NET #1223

Closed
danielvoilaLEGO opened this issue Mar 15, 2021 · 1 comment · Fixed by #1548
Closed

RabbitMQ support for .NET #1223

danielvoilaLEGO opened this issue Mar 15, 2021 · 1 comment · Fixed by #1548
Assignees
@russcam
Labels
8.1-candidate agent-dotnet enhancement New feature or request

Comments

@danielvoilaLEGO
Copy link

Hello,

Is RabbitMQ support for .NET planned to be available in the near future?

Thank you!
@felixbarny felixbarny transferred this issue from elastic/apm Mar 15, 2021
@gregkalapos
Copy link
Contributor

Hi @danielvoilaLEGO ,

we are currently working on Azure ServiceBus - that'll add the basis for messaging and from that point likely we can easily offer an API to also capture messaging related things manually.

Specifically for RabbitMQ we are watching rabbitmq/rabbitmq-dotnet-client#776. If that happens we can add auto instrumentation fairly easily, if it doesn't happen we'll need to come up with something else which'll be more work.

@russcam russcam self-assigned this Nov 5, 2021
@russcam russcam added the enhancement New feature or request label Nov 5, 2021
russcam added a commit to russcam/apm-agent-dotnet that referenced this issue Nov 8, 2021
@russcam
Add auto instrumentation for RabbitMQ
ecc5a2a 
This commit adds profiler auto instrumentation for RabbitMQ.
The instrumentation follows the messaging spec and aligns with
the Elastic APM Java agent implementation.

The following RabbitMQ.Client operations are instrumented:

- BasicGet

  Creates POLL spans if there is an active transaction

- BasicPublish

  Creates SEND spans if there is an active transaction

- HandleBasicDeliver in EventingBasicConsumer

  Creates RECEIVE transactions around the message
  processing flow

Trace Context is propagated through message headers
for distributed tracing.

Closes elastic#1223
@russcam russcam mentioned this issue Nov 8, 2021
Merged
russcam added a commit that referenced this issue Nov 11, 2021
@russcam
Add auto instrumentation for RabbitMQ (#1548)
d5e37cc 
This commit adds profiler auto instrumentation for RabbitMQ.
The instrumentation follows the messaging spec and aligns with
the Elastic APM Java agent implementation.

The following RabbitMQ.Client operations are instrumented:

- BasicGet

  Creates POLL spans if there is an active transaction

- BasicPublish

  Creates SEND spans if there is an active transaction

- HandleBasicDeliver in EventingBasicConsumer

  Creates RECEIVE transactions around the message
  processing flow

Trace Context is propagated through message headers
for distributed tracing.

Closes #1223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russcam russcam

Labels
8.1-candidate agent-dotnet enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add auto instrumentation for RabbitMQ russcam/apm-agent-dotnet
4 participants
@russcam @AlexanderWert @gregkalapos @danielvoilaLEGO