Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for RequestBodyMaxLength #1359

Open
fuzolan opened this issue Jul 27, 2021 · 2 comments
Open

Config for RequestBodyMaxLength #1359

fuzolan opened this issue Jul 27, 2021 · 2 comments
Assignees
Labels
agent-dotnet enhancement New feature or request

Comments

@fuzolan
Copy link

fuzolan commented Jul 27, 2021

The fixed value of 2048 could be rather limiting. Is there a technical issue, to capture bigger bodies?
If I'm not misstaken, the java client has a bigger limit here.

It would be really nice, if this would be a config parameter for the client.

@gregkalapos
Copy link
Contributor

Is there a technical issue, to capture bigger bodies?

No there isn't - by looking at the PR which introduces it, it seems it was an arbitrary choice. We definitely want limit this and not capture super long bodies, but the 2k limit isn't based on some specific thing.

If I'm not mistaken, the java client has a bigger limit here.

Correct, they use a 10K limit.

It would be really nice, if this would be a config parameter for the client.

Java has the same ask: elastic/apm-agent-java#456

So, as a next step I opened #1368 - if that gets merged the limit will be 10K in the next release.

I also leave this open and try to propose a cross agent setting to give users the option to change the limit. (fyi: if we introduce a setting then preferably we'd do that across all agents and not just for .NET).

elastic/apm-agent-java#456

@sean-jost
Copy link

sean-jost commented May 23, 2024

Have a need for this in .net agent. Would be nice if we can get long_string_max_length implemented, as defined in elastic/apm#488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-dotnet enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants