Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement: Agent should not auto capture spans that will be discarded #474

Closed
SergeyKleyman opened this issue Sep 5, 2019 · 2 comments
Labels
enhancement New feature or request performance Items related to performance

Comments

@SergeyKleyman
Copy link
Contributor

SergeyKleyman commented Sep 5, 2019

Current implementation auto captures spans (HTTP calls and DB operation for EF Core) even if those spans will be later discarded because the transaction is not sampled or it reached "transaction max spans" (assuming we already implemented the latter - see #178, #472)

Note: we might need to still capture some information for "to be discarded" spans in order to include it in breakdown metrics (#227) but we can still improve performance by not doing anything is not necessary for breakdown metrics. For example we can omit parsing DB statement, etc.

@SergeyKleyman SergeyKleyman added enhancement New feature or request performance Items related to performance labels Sep 5, 2019
@SergeyKleyman SergeyKleyman changed the title Agent should not auto capture spans that will be not sampled/discarded as a performance improvement Performance improvement: Agent should not auto capture spans that will be discarded Sep 5, 2019
@lreuven lreuven modified the milestone: 7.5 Sep 26, 2019
@russcam
Copy link
Contributor

russcam commented Nov 4, 2021

This issue may have less relevance now, with the dropped span stats implementation: #1511.

@gregkalapos I suggest we close this for now, and can reopen or open a new issue when looking at this in detail.

@gregkalapos
Copy link
Contributor

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Items related to performance
Projects
None yet
Development

No branches or pull requests

4 participants