Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openJ9 JDK11 with tomcat fails to propagate context #2203

Closed
jackshirazi opened this issue Oct 19, 2021 · 3 comments · Fixed by #2341
Closed

openJ9 JDK11 with tomcat fails to propagate context #2203

jackshirazi opened this issue Oct 19, 2021 · 3 comments · Fixed by #2341

Comments

@jackshirazi
Copy link
Contributor

jackshirazi commented Oct 19, 2021

Describe the bug

For both JakartaeeTomcatIT and TomcatIT classes in the integration test suite, OpenJ9 on JDK11 testing fails (classes have those configuration of tests commented out for now). The attached log shows the test run error, it appears to be because of JDK9+ modularization access changes

Steps to reproduce

  1. Uncomment any of the commented out lines in JakartaeeTomcatIT and TomcatIT classes in the integration test suite and run the test (eg lines shown here)
            // TODO openj9 on JDK11 has an access problem from java.base
            //{"10.0.10-jdk1
[error.txt](https://github.com/elastic/apm-agent-java/files/7373275/error.txt)
1-adoptopenjdk-openj9"},

Expected behavior

Expect the test to pass with no failure, as per all the other tests in the same class (eg hotspot on jdk11 is fine)

Debug logs

attached holds the output of the failed test run

@jackshirazi
Copy link
Contributor Author

error.txt

@eyalkoren
Copy link
Contributor

See #1415 and the fix we applied through #1468, look into why the same fix doesn't apply in this JVM.
Could be something stupid like this check failing.

@SylvainJuge
Copy link
Member

The test still fails after fixing the module access issue with #2341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants