From 0f28a164e998b1db90b2d46cce087e1e828ec9be Mon Sep 17 00:00:00 2001 From: Trent Mick Date: Wed, 25 Aug 2021 15:06:19 -0700 Subject: [PATCH] fix: test crash with mongodb@4.1.1 and node v10 (#2303) mongodb@4.0.0 dropped support for node v10. However, it wasn't until v4.1.1 that it failed in usage with the latest node v10. --- test/config.test.js | 4 ++-- test/instrumentation/modules/mongodb.test.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/config.test.js b/test/config.test.js index f6a604d056a..04fc1bb1877 100644 --- a/test/config.test.js +++ b/test/config.test.js @@ -732,9 +732,9 @@ test('disableInstrumentations', function (t) { if (semver.lt(process.version, '10.0.0') && semver.gte(esVersion, '7.12.0')) { modules.delete('@elastic/elasticsearch') } - // require('mongodb') is a hard crash on nodes < 10.4 + // As of mongodb@4 only supports node >=v12. const mongodbVersion = require('../node_modules/mongodb/package.json').version - if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '10.4.0')) { + if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '12.0.0')) { modules.delete('mongodb') } diff --git a/test/instrumentation/modules/mongodb.test.js b/test/instrumentation/modules/mongodb.test.js index 666eb4400d9..5725046f7ab 100644 --- a/test/instrumentation/modules/mongodb.test.js +++ b/test/instrumentation/modules/mongodb.test.js @@ -8,10 +8,10 @@ const agent = require('../../..').start({ cloudProvider: 'none' }) -// require('mongodb') is a hard crash on nodes <10.4 +// As of mongodb@4 only supports node >=v12. const mongodbVersion = require('../../../node_modules/mongodb/package.json').version const semver = require('semver') -if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '10.4.0')) { +if (semver.gte(mongodbVersion, '4.0.0') && semver.lt(process.version, '12.0.0')) { console.log(`# SKIP mongodb@${mongodbVersion} does not support node ${process.version}`) process.exit() }