Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop HTTP spans under S3 spans #2125

Closed
trentm opened this issue Jun 22, 2021 · 0 comments · Fixed by #2552
Closed

drop HTTP spans under S3 spans #2125

trentm opened this issue Jun 22, 2021 · 0 comments · Fixed by #2552
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
8.1

Comments

@trentm
Copy link
Member

trentm commented Jun 22, 2021 •
edited by zube bot
Loading

#2112 adds instrumention of S3 (the aws-sdk package). Each S3 span currently also results in an HTTP span for the underlying S3 API call. As with Elasticsearch and SQS, we would like to exclude these HTTP spans, so the S3 spans are exit spans and breakdown metrics point to S3, not somewhat misleadingly to HTTP.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 22, 2021
@trentm trentm mentioned this issue Jun 23, 2021
Merged
5 tasks
@trentm trentm mentioned this issue Sep 30, 2021
Merged
5 tasks
@AlexanderWert AlexanderWert added this to the 8.0 milestone Oct 18, 2021
@trentm trentm mentioned this issue Oct 28, 2021
Closed
@AlexanderWert AlexanderWert modified the milestones: 8.0, 8.1 Dec 6, 2021
@trentm trentm self-assigned this Jan 28, 2022
trentm added a commit that referenced this issue Jan 28, 2022
@trentm
feat: introduce "exit spans" and mark S3 spans as exit spans
6cfb2ef 
Per https://github.com/elastic/apm/blob/main/specs/agents/tracing-spans.md#exit-spans
the result is that HTTP child spans of S3 spans are no longer captured.

Closes: #2125
@trentm trentm mentioned this issue Jan 28, 2022
Merged
7 tasks
trentm added a commit that referenced this issue Jan 31, 2022
@trentm
feat: introduce "exit spans" and mark S3 spans as exit spans (#2552)
520a901 
Per https://github.com/elastic/apm/blob/main/specs/agents/tracing-spans.md#exit-spans
the result is that HTTP child spans of S3 spans are no longer captured.

Also:
- Add http context to the S3 spans, now that the http spans are gone some
  of this info might be helpful.
- Update TAV versions for aws-sdk to something more reasonable.

Closes: #2125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

feat: introduce "exit spans" and mark S3 spans as exit spans elastic/apm-agent-nodejs
2 participants
@trentm @AlexanderWert