Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn on errorMessageMaxLength deprecated config option usage #2314

Closed
trentm opened this issue Sep 1, 2021 · 2 comments
Closed

warn on errorMessageMaxLength deprecated config option usage #2314

trentm opened this issue Sep 1, 2021 · 2 comments
Assignees
@david-luna
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
next-major

Comments

@trentm
Copy link
Member

trentm commented Sep 1, 2021 •
edited
Loading

The errorMessageMaxLength option was deprecated by longFieldMaxLength in #2193. The option should be removed for the next major version.

Update (2023-07): Let's just warn with process.emitWarning (... or log.warn?)
@trentm trentm added this to the next-major milestone Sep 1, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 1, 2021
@trentm trentm changed the title remove errorMessageMaxLength deprecated config option warn on errorMessageMaxLength deprecated config option usage Jul 25, 2023
@david-luna david-luna self-assigned this Aug 3, 2023
@david-luna
Copy link
Member

As discussed we will log.warn

@david-luna david-luna mentioned this issue Aug 4, 2023
Merged
6 tasks
trentm added a commit that referenced this issue Aug 4, 2023
@david-luna @trentm
chore: warn for missing size units in config and for `errorMessagesMa…
be4e6e5 
…xLength` usage (#3553)

Closes: #2121
Closes: #2314
Co-authored-by: Trent Mick <[email protected]>
@trentm
Copy link
Member Author

trentm commented Aug 4, 2023

This was done in #3553 on the "dev/4.x" branch, which will be the active 4.x release branch soonish.

@trentm trentm closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-luna david-luna

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
next-major
Development

No branches or pull requests
2 participants
@trentm @david-luna