Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 619] Change default behavior for span compression and dropping of spans #2619

Closed
2 tasks done
AlexanderWert opened this issue Mar 23, 2022 · 3 comments
Closed
2 tasks done

[META 619] Change default behavior for span compression and dropping of spans #2619

AlexanderWert opened this issue Mar 23, 2022 · 3 comments
Labels
agent-nodejs Make available for APM Agents project planning.
Milestone
8.3

Comments

@AlexanderWert
Copy link
Member

AlexanderWert commented Mar 23, 2022 •
edited by trentm
Loading

issue details

Spec change: elastic/apm#611

This includes:

  • Change default value for span_compression_enabled to true
  • Change default value for span_compression_same_kind_max_duration to 0ms
@AlexanderWert AlexanderWert mentioned this issue Mar 23, 2022
Open
8 tasks
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 23, 2022
@trentm
Copy link
Member

trentm commented Mar 23, 2022

I'm guessing this'll just happen as part of #2100

@trentm trentm added this to the 8.3 milestone Apr 20, 2022
@trentm
Copy link
Member

trentm commented Apr 20, 2022

Added to the 8.3 milestone because I think Alan's impl of span compression in 8.3 will just do this automatically... because the Node.js APM agent impl came after this spec change.

@trentm
Copy link
Member

trentm commented Apr 27, 2022

Done in #2656 and #2623
(/cc @astorm)

@trentm trentm closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
8.3
Development

No branches or pull requests
2 participants
@trentm @AlexanderWert