Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META 448] Auto-infer destination.service.resource and adapt public API #426

Open
2 of 4 tasks
elastic-apm-tech opened this issue Jun 9, 2021 · 0 comments
Open
2 of 4 tasks
Labels
agent-php cross APM agents Part of the alignment with the rest of Elastic APM priority: low triaged

Comments

@elastic-apm-tech
Copy link

elastic-apm-tech commented Jun 9, 2021

As described in elastic/apm#448, the agent needs to apply the following changes to comply with the current SPEC for destination fields:

  • Infer destination.service.resource based on other fields
  • Add a public API to set destination.service.resource
  • As destination.service.name and destination.service.type are not used anywhere in the product, I propose to deprecate and remove them also in the public API (if already added there)
  • Add a public API to start an exit span. This auto-infers the destination.service.resource based on the subtype if not set otherwise. Avoids creating nested exit spans and makes the service map work with those custom spans by default, without having to set any destination fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-php cross APM agents Part of the alignment with the rest of Elastic APM priority: low triaged
Projects
None yet
Development

No branches or pull requests

3 participants