Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 448] Auto-infer destination.service.resource and adapt public API #1159

Closed
4 tasks
elastic-apm-tech opened this issue Jun 9, 2021 · 0 comments · Fixed by #1359
Closed
4 tasks

[META 448] Auto-infer destination.service.resource and adapt public API #1159

elastic-apm-tech opened this issue Jun 9, 2021 · 0 comments · Fixed by #1359
Assignees
@beniwohli
Labels
agent-python
Milestone
7.16

Comments

@elastic-apm-tech
Copy link

As described in elastic/apm#448, the agent needs to apply the following changes to comply with the current SPEC for destination fields:

  • Infer destination.service.resource based on other fields
  • Add a public API to set destination.service.resource
  • As destination.service.name and destination.service.type are not used anywhere in the product, I propose to deprecate and remove them also in the public API (if already added there)
  • Add a public API to start an exit span. This auto-infers the destination.service.resource based on the subtype if not set otherwise. Avoids creating nested exit spans and makes the service map work with those custom spans by default, without having to set any destination fields.
@elastic-apm-tech elastic-apm-tech added this to the 7.15 milestone Jun 9, 2021
This was referenced Jun 9, 2021
Open
Closed
@AlexanderWert AlexanderWert modified the milestones: 7.15, 7.16 Aug 24, 2021
@beniwohli beniwohli self-assigned this Sep 8, 2021
@beniwohli beniwohli mentioned this issue Sep 14, 2021
Merged
beniwohli added a commit to beniwohli/apm-agent-python that referenced this issue Oct 13, 2021
@beniwohli
implement auto-inference of destination resource
c80e232 
closes elastic#1159
@beniwohli beniwohli mentioned this issue Oct 13, 2021
Merged
basepi pushed a commit that referenced this issue Oct 18, 2021
@beniwohli
implement auto-inference of destination resource (#1359)
5ae5cf6 
* implement auto-inference of destination resource

closes #1159

* fix a bunch of tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beniwohli beniwohli

Labels
agent-python
Projects
None yet
Milestone
7.16
Development

Successfully merging a pull request may close this issue.

implement auto-inference of destination resource beniwohli/apm-agent-python
3 participants
@beniwohli @AlexanderWert @elastic-apm-tech