Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between service-level labels and user-specific labels #1356

Open
dgieselaar opened this issue Mar 27, 2023 · 1 comment
Open

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Mar 27, 2023

Currently, any label added via addLabels() is treated as a "global" label. Global labels are part of the aggregation key of (service) transaction metrics, meaning that the user risks creating a high amount of metric groups that will result in APM Server pushing data into an overflow bucket. This can happen if user-specific labels or metrics are added via the addLabels() API. For 8.7.1 we are removing global labels from the aggregation key for the RUM agent (elastic/apm-server#10532). Beyond that, we need a better fix that gives the user the option to aggregate on service-specific labels. I'm not sure what exactly, but perhaps we can add a new addGlobalLabels() API, not sure if that is the best option though.

--
Additional context: https://elastic.slack.com/archives/C5L79P420/p1679555445014589

@paulb-elastic
Copy link

Discussed with @felixbarny and will work on this in the future when we plan in a bigger scoped breaking change in the RUM agent. The APM Server work around will continue to be the mitigation for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants