Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing block method in type declaration #1358

Open
ldgrp opened this issue Mar 31, 2023 · 2 comments
Open

Missing block method in type declaration #1358

ldgrp opened this issue Mar 31, 2023 · 2 comments

Comments

@ldgrp
Copy link

ldgrp commented Mar 31, 2023

The API reference documents the existence of transaction.block https://www.elastic.co/guide/en/apm/agent/rum-js/current/transaction-api.html#transaction-block

It appears to be a public method of Transaction here

But is not included in the type declaration

export class Transaction extends BaseSpan {
startSpan(
name?: string | null,
type?: string | null,
options?: SpanOptions
): Span | undefined
mark(key: string): void
/**
* undocumented, might be removed in future versions
*/
addTask(taskId: TaskId): TaskId
/**
* undocumented, might be removed in future versions
*/
removeTask(taskId: TaskId): void
/**
* undocumented, might be removed in future versions
*/
captureBreakdown(): void
/**
* undocumented, might be removed in future versions
*/
isFinished(): boolean
}

@ldgrp ldgrp changed the title Missing block method in type declaration Missing block method in type declaration Mar 31, 2023
@ldgrp
Copy link
Author

ldgrp commented Mar 31, 2023

I think this might be related #1267

@devcorpio
Copy link
Contributor

Hi @ldgrp,

Thanks for pointing it out, much appreciated

For the time being, if the missing type declaration is causing you any issues you could apply the workaround described here

Cheers,
Alberto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants