Allow enabling franz-go logging from kafka package
#540
Comments
inge4pres
added a commit
that referenced
this issue
Aug 12, 2024
The current `metricsHook` struct that collects metrics based on Kafka hooks is not equipped to also report details of _why_ connection errors are caused. --- Details We provide a new struct that implements a (single, for now) kgo Hook dedicated to logging errors during the broker connection phase. The struct can be iterated in the future to implement other monitoring hooks, providing logging utilities where the metrics would have too high cardinality. The proposed design adds the new logger hook behind the `CommonConfig.DisableTelemetry` flag (similarly to the metrics hook). This can be improved and it is not a perfect solution, but it has to be done this way until a bigger refactor is done to expose the `CommonConfig.hook` fieldin some way. The more idiomatic, but also more expensive, solution would be to allow exporting franz-go logs into the Logger. This is mentioned in #540 --------- Signed-off-by: inge4pres <[email protected]> Co-authored-by: Edoardo Tenani <[email protected]>
|
Clarification: when we decide to pursue logging the entirety of messages from franz-go, we can remove what's been added in #541.
The previous note is assuming that we want to reduce the amount of data stored in our logging infrastructure, or at least limit to what's actually useful. |
|
moving this from it105 to 109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
kafkapackage does not initializefranz-gologging nor exposes a way to do this. This means there is no way for callers to enablefranz-gologging.Goal
Allow enabling
franz-gologging fromkafkapackage callers.The text was updated successfully, but these errors were encountered: