Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove context.db from S3 spans: S3 isn't a database #696

Open
1 of 2 tasks
trentm opened this issue Oct 3, 2022 · 0 comments
Open
1 of 2 tasks

Remove context.db from S3 spans: S3 isn't a database #696

trentm opened this issue Oct 3, 2022 · 0 comments

Comments

@trentm
Copy link
Member

trentm commented Oct 3, 2022

Description

context.db.* was added to the spec for AWS S3 spans by accident. As of spec change #683 any S3 spans created by APM agent instrumentation should not set span.context.db.*.

(My read of the Go and Python APM agent implementations was that they already do not set context.db.* for S3 spans, so I didn't create implementation PRs for them.)

Agent Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant