Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Added ability to search API logs #24

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Added ability to search API logs #24

merged 5 commits into from
Jul 30, 2020

Conversation

jsma
Copy link
Contributor

@jsma jsma commented Mar 31, 2020

No description provided.

SamSchelfhout
SamSchelfhout previously approved these changes Jul 20, 2020
Copy link
Member

@JasonStoltz JasonStoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sincerely sorry for taking so long to review this. This looks good to me, just a couple of tweaks please.

If you can make these changes and update your branch I am happy to merge and include in a release next week.

README.md Outdated Show resolved Hide resolved
README.md Outdated
"status": "429",
}
})
{'results': [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the formatting here to match the formatting of other responses in this README?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I don't recall if that was the copied/pasted output or where that formatting came from. Not be facetious at all, but I'm not sure which format you prefer. I see examples of "pretty" formatted output, one-liners, and one-liners with elided output:

Screen Shot 2020-07-29 at 9 39 18 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a great point. How about "pretty"?

@JasonStoltz JasonStoltz added this to the v7.8.1 milestone Jul 30, 2020
@JasonStoltz JasonStoltz merged commit c659348 into elastic:master Jul 30, 2020
@JasonStoltz
Copy link
Member

Thanks again for adding this. I'm going to merge and include in a patch release, 7.8.1, shortly.

@jsma jsma deleted the search-api-logs branch July 30, 2020 15:10
@JasonStoltz JasonStoltz linked an issue Jul 30, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base_endpoint should accept protocol
3 participants