Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support SearchKey as an Environment Variable #82

Open
christophercutajar opened this issue Jul 21, 2021 · 2 comments
Open

Comments

@christophercutajar
Copy link
Contributor

christophercutajar commented Jul 21, 2021

Having the searchKey in the clear in engine.json is not the best approaches from a security point of view.

It would be great if the searchKey can be read at runtime from an environment variable.

As an example the AppSearchAPIConnector connector would be something like the following:

const connector = new AppSearchAPIConnector({
  searchKey: process.env.REACT_APP_APPSEARCH_SEARCHKEY,
  engineName,
  hostIdentifier,
  endpointBase
});

Would like to get your opinion on this before performing any work. Ready to submit a PR for this feature 😄

@JasonStoltz
Copy link
Member

JasonStoltz commented Jul 21, 2021

That's a good idea. We'd need to update the README to change the start command to include the environment variable. We'll also need to make the corresponding change in App Search, which could target 7.15.

@christophercutajar
Copy link
Contributor Author

Raised #83 for ReferenceUI. I'm not sure what changes are required in AppSearch to the download ZIP package feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants