[8.16](backport #42705) feat: bump go version to 1.23 (#43009)

mergify[bot] · kruskall · AndersonQ · web-flow · commit 7856686112f9 · 2025-03-14T13:54:59.000+01:00
* feat: bump go version to 1.23 (#42705) * feat: bump go version to 1.23 * Update CHANGELOG.next.asciidoc * Update packaging.sh * Update packaging.sh * use the aarch image instead of the alias * we don't use qemu on ARM64 * fix packaging --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit eafca95) # Conflicts: # libbeat/docs/version.asciidoc * Update version.asciidoc * fix changelog * fix changelog --------- Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com> Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co> Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
diff --git a/.buildkite/metricbeat/pipeline.yml b/.buildkite/metricbeat/pipeline.yml
@@ -146,7 +146,9 @@ steps:
 
       - label: ":ubuntu: Metricbeat: Crosscompile"
         key: "mandatory-cross-compile"
-        command: "make -C metricbeat crosscompile"
+        command: |
+          source .buildkite/scripts/qemu.sh
+          make -C metricbeat crosscompile
         retry:
           automatic:
             - limit: 1
diff --git a/.buildkite/scripts/packaging/packaging.sh b/.buildkite/scripts/packaging/packaging.sh
@@ -1,19 +1,14 @@
 #!/usr/bin/env bash
 #
 # Centralise the mage package for a given beat in Buildkite.
-# It enables multi-arch builds to avoid the exec format errors when 
-# attempting to build arm64 inside arm64 workers.
-# For further details, see https://github.com/elastic/elastic-agent/pull/6948
-# and https://github.com/elastic/golang-crossbuild/pull/507
 #
 
 set -ueo pipefail
 
-
 BEAT_DIR=${1:?-"Error: Beat directory must be specified."}
 
-#Use newer multiarch support for packaging
-docker run --privileged --rm tonistiigi/binfmt:master --install all
+# shellcheck source=/dev/null
+source .buildkite/scripts/qemu.sh
 
 cd $BEAT_DIR
 mage package
diff --git a/.buildkite/scripts/qemu.sh b/.buildkite/scripts/qemu.sh
@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+#
+# It enables multi-arch builds to avoid the exec format errors when 
+# attempting to build arm64 inside arm64 workers.
+#
+# For further details, see https://github.com/elastic/elastic-agent/pull/6948
+# and https://github.com/elastic/golang-crossbuild/pull/507
+#
+set -euo pipefail
+
+if [[ "$(uname -m)" == "aarch64" || "$(uname -m)" == "arm64" ]]; then
+    echo "Skipping qemu installation on arm64 worker"
+else
+    BINFMT_IMAGE="tonistiigi/binfmt:qemu-v9.2.2"
+
+    # Make sure to uninstall first to avoid conflicts
+    docker run --privileged --rm "$BINFMT_IMAGE" --uninstall qemu-*
+    docker run --privileged --rm "$BINFMT_IMAGE" --install all
+fi
diff --git a/.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml b/.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml
@@ -64,6 +64,7 @@ steps:
       - label: ":ubuntu: x-pack/dockerlogbeat: Ubuntu x86_64 Unit Tests"
         key: "mandatory-linux-unit-test"
         command: |
+          source .buildkite/scripts/qemu.sh
           cd x-pack/dockerlogbeat
           mage build unitTest
         retry:
diff --git a/.go-version b/.go-version
@@ -1 +1 @@
-1.22.12
+1.23.6
diff --git a/.golangci.yml b/.golangci.yml
@@ -150,10 +150,6 @@ linters-settings:
       - github.com/meraki/dashboard-api-go/v3
       - github.com/snowflakedb/gosnowflake
 
-  gosimple:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.22.12"
-
   nakedret:
     # make an issue if func has more lines of code than this setting and it has naked returns; default is 30
     max-func-lines: 0
@@ -169,21 +165,13 @@ linters-settings:
     require-specific: false
 
   staticcheck:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.22.12"
     checks: ["all"]
 
   stylecheck:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.22.12"
     # Disabled:
     # ST1005: error strings should not be capitalized
     checks: ["all", "-ST1005"]
 
-  unused:
-    # Select the Go version to target. The default is '1.13'.
-    go: "1.22.12"
-
   gosec:
     excludes:
     - G306 # Expect WriteFile permissions to be 0600 or less
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -176,6 +176,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
 - elasticsearch output now supports `idle_connection_timeout`. {issue}35616[35615] {pull}36843[36843]
 - Enable early event encoding in the Elasticsearch output, improving cpu and memory use {pull}38572[38572]
 - The environment variable `BEATS_ADD_CLOUD_METADATA_PROVIDERS` overrides configured/default `add_cloud_metadata` providers {pull}38669[38669]
+- Update to Go 1.23.6. {pull}42705[42705]
 
 *Auditbeat*
 
diff --git a/auditbeat/Dockerfile b/auditbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.22.12
+FROM golang:1.23.6
 
 RUN \
     apt-get update \
diff --git a/dev-tools/kubernetes/filebeat/Dockerfile.debug b/dev-tools/kubernetes/filebeat/Dockerfile.debug
@@ -1,4 +1,4 @@
-FROM golang:1.22.12 as builder
+FROM golang:1.23.6 as builder
 
 ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin
 
diff --git a/dev-tools/kubernetes/heartbeat/Dockerfile.debug b/dev-tools/kubernetes/heartbeat/Dockerfile.debug
@@ -1,4 +1,4 @@
-FROM golang:1.22.12 as builder
+FROM golang:1.23.6 as builder
 
 ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin
 
diff --git a/dev-tools/kubernetes/metricbeat/Dockerfile.debug b/dev-tools/kubernetes/metricbeat/Dockerfile.debug
@@ -1,4 +1,4 @@
-FROM golang:1.22.12 as builder
+FROM golang:1.23.6 as builder
 
 ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin
 
diff --git a/dev-tools/mage/crossbuild.go b/dev-tools/mage/crossbuild.go
@@ -227,7 +227,7 @@ func CrossBuildImage(platform string) (string, error) {
 	case platform == "darwin/universal":
 		tagSuffix = "darwin-arm64-debian10"
 	case platform == "linux/arm64":
-		tagSuffix = "arm"
+		tagSuffix = "base-arm-debian9"
 	case platform == "linux/armv5":
 		tagSuffix = "armel"
 	case platform == "linux/armv6":
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/elastic/beats/v7
 
-go 1.22.12
+go 1.23.6
 
 require (
 	cloud.google.com/go/bigquery v1.62.0
diff --git a/heartbeat/Dockerfile b/heartbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.22.12
+FROM golang:1.23.6
 
 RUN \
     apt-get update \
diff --git a/libbeat/docs/version.asciidoc b/libbeat/docs/version.asciidoc
@@ -1,6 +1,6 @@
 :stack-version: 8.16.5
 :doc-branch: 8.16
-:go-version: 1.22.10
+:go-version: 1.23.6
 :release-state: unreleased
 :python: 3.7
 :docker: 1.12
diff --git a/metricbeat/Dockerfile b/metricbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.22.12
+FROM golang:1.23.6
 COPY --from=docker:26.0.0-alpine3.19 /usr/local/bin/docker  /usr/local/bin/
 
 RUN \
diff --git a/metricbeat/module/http/_meta/Dockerfile b/metricbeat/module/http/_meta/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.22.12
+FROM golang:1.23.6
 
 COPY test/main.go main.go
 
diff --git a/metricbeat/module/nats/_meta/Dockerfile b/metricbeat/module/nats/_meta/Dockerfile
@@ -2,7 +2,7 @@ ARG NATS_VERSION=2.0.4
 FROM nats:$NATS_VERSION
 
 # build stage
-FROM golang:1.22.12 AS build-env
+FROM golang:1.23.6 AS build-env
 RUN apt-get install git mercurial gcc
 RUN git clone https://github.com/nats-io/nats.go.git /nats-go
 RUN cd /nats-go/examples/nats-bench && git checkout tags/v1.10.0 && go build .
diff --git a/metricbeat/module/vsphere/_meta/Dockerfile b/metricbeat/module/vsphere/_meta/Dockerfile
@@ -1,5 +1,5 @@
 ARG VSPHERE_GOLANG_VERSION
-FROM golang:1.22.12
+FROM golang:1.23.6
 
 RUN apt-get install curl git
 RUN go install github.com/vmware/govmomi/vcsim@v0.30.4
diff --git a/packetbeat/Dockerfile b/packetbeat/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.22.12
+FROM golang:1.23.6
 
 RUN \
     apt-get update \
diff --git a/x-pack/metricbeat/module/stan/_meta/Dockerfile b/x-pack/metricbeat/module/stan/_meta/Dockerfile
@@ -2,7 +2,7 @@ ARG STAN_VERSION=0.15.1
 FROM nats-streaming:$STAN_VERSION
 
 # build stage
-FROM golang:1.22.12 AS build-env
+FROM golang:1.23.6 AS build-env
 RUN apt-get install git mercurial gcc
 RUN git clone https://github.com/nats-io/stan.go.git /stan-go
 RUN cd /stan-go/examples/stan-bench && git checkout tags/v0.5.2 && go build .

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.22.12`
	`1`	`+FROM golang:1.23.6`
`2`	`2`
`3`	`3`	`RUN \`
`4`	`4`	`apt-get update \`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.22.12 as builder`
	`1`	`+FROM golang:1.23.6 as builder`
`2`	`2`
`3`	`3`	`ENV PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/go/bin:/usr/local/go/bin`
`4`	`4`