Skip to content

Postgres advanced sync rules missing in Native Connectors #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seanstory opened this issue Jul 8, 2024 · 2 comments
Closed

Postgres advanced sync rules missing in Native Connectors #2686

seanstory opened this issue Jul 8, 2024 · 2 comments
Labels
bug Something isn't working priority:medium team:external

Comments

@seanstory
Copy link
Member

seanstory commented Jul 8, 2024 •
edited
Loading

Bug Description

https://github.com/elastic/kibana/blob/dd9d6434cae8b7beb3b730cd42898b8f63dbee91/packages/kbn-search-connectors/types/native_connectors.ts#L3867 specifies that Advanced Sync Rules for the Postgres Native Connector are disabled. But these should have been enabled as part of #1691 for 8.11

To Reproduce

  • create a postgres native connector
  • try to add advanced sync rules

Expected behavior

Advanced Sync Rules should be available

Screenshots

image

Environment

8.11-8.14

Workaround

Get the connector's ID. You can find this by doing a GET .elastic-connectors/_search and looking for the right connector. Then execute the below Elasticsearch request, replacing <connector_id> with your connector's ID.

POST .elastic-connectors/_update/<connector_id>
{
  "doc": {
    "features": {
      "sync_rules": {
        "advanced": {
          "enabled": true
         }
      }
    }
  }
}
@seanstory seanstory added bug Something isn't working team:external labels Jul 8, 2024
@praveen-kukreja
Copy link
Contributor

But these should have been enabled as part of #1691 for 8.11

@seanstory back in September, 2023 when this PR for Postgres #1691 got merged there was no checklist that stated raising a PR on Kibana for native connector changes. The Checklist item might have been introduced later. Before that, the changes to Kibana files was being taken care by Elastic.

However, we're happy to fix this.

@praveen-kukreja praveen-kukreja mentioned this issue Jul 21, 2024
Merged
2 tasks
@praveen-kukreja
Copy link
Contributor

praveen-kukreja commented Jul 22, 2024 •
edited
Loading

Upon further investigation it was found that some more connectors were having similar issue. This was determined by checking which connectors has support for Advanced sync rules using: https://github.com/search?q=repo%3Aelastic%2Fconnectors+%22advanced_rules_enabled+%3D+True%22&type=code

cc @navarone-feekery

navarone-feekery added a commit to elastic/kibana that referenced this issue Jul 23, 2024
@praveen-kukreja @navarone-feekery
[Search] Fix missing sync rules in native connectors (#188803)
87e2f03 
## Part of elastic/connectors#2686 

## Summary

The following set of connectors gained support for the advanced sync
rules feature in a later release compared to the one where they were
made available as native connector. Consequently, enabling advanced
rules for these connectors was missed.
- Postgres
- Network Drive
- MSSQL
- GitHub
- OneDrive
- Salesforce
- S3
- GMail
- Notion

Co-authored-by: Navarone Feekery <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 23, 2024
@praveen-kukreja
[Search] Fix missing sync rules in native connectors (elastic#188803)
718f099 
## Part of elastic/connectors#2686

## Summary

The following set of connectors gained support for the advanced sync
rules feature in a later release compared to the one where they were
made available as native connector. Consequently, enabling advanced
rules for these connectors was missed.
- Postgres
- Network Drive
- MSSQL
- GitHub
- OneDrive
- Salesforce
- S3
- GMail
- Notion

Co-authored-by: Navarone Feekery <[email protected]>
(cherry picked from commit 87e2f03)
kibanamachine added a commit to elastic/kibana that referenced this issue Jul 23, 2024
@kibanamachine @praveen-kukreja
[8.15] [Search] Fix missing sync rules in native connectors (#188803) (…
55aa8f1 
…#188938)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Search] Fix missing sync rules in native connectors
(#188803)](#188803)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Praveen
Kukreja","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-23T12:38:16Z","message":"[Search]
Fix missing sync rules in native connectors (#188803)\n\n## Part of
elastic/connectors#2686 \r\n\r\n##
Summary\r\n\r\nThe following set of connectors gained support for the
advanced sync\r\nrules feature in a later release compared to the one
where they were\r\nmade available as native connector. Consequently,
enabling advanced\r\nrules for these connectors was missed.\r\n-
Postgres\r\n- Network Drive\r\n- MSSQL\r\n- GitHub\r\n- OneDrive\r\n-
Salesforce\r\n- S3\r\n- GMail\r\n- Notion\r\n\r\nCo-authored-by:
Navarone Feekery
<[email protected]>","sha":"87e2f037786f576c6b8f40037a6362147db15145","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.15.0","v8.16.0"],"title":"[Search]
Fix missing sync rules in native
connectors","number":188803,"url":"https://github.com/elastic/kibana/pull/188803","mergeCommit":{"message":"[Search]
Fix missing sync rules in native connectors (#188803)\n\n## Part of
elastic/connectors#2686 \r\n\r\n##
Summary\r\n\r\nThe following set of connectors gained support for the
advanced sync\r\nrules feature in a later release compared to the one
where they were\r\nmade available as native connector. Consequently,
enabling advanced\r\nrules for these connectors was missed.\r\n-
Postgres\r\n- Network Drive\r\n- MSSQL\r\n- GitHub\r\n- OneDrive\r\n-
Salesforce\r\n- S3\r\n- GMail\r\n- Notion\r\n\r\nCo-authored-by:
Navarone Feekery
<[email protected]>","sha":"87e2f037786f576c6b8f40037a6362147db15145"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188803","number":188803,"mergeCommit":{"message":"[Search]
Fix missing sync rules in native connectors (#188803)\n\n## Part of
elastic/connectors#2686 \r\n\r\n##
Summary\r\n\r\nThe following set of connectors gained support for the
advanced sync\r\nrules feature in a later release compared to the one
where they were\r\nmade available as native connector. Consequently,
enabling advanced\r\nrules for these connectors was missed.\r\n-
Postgres\r\n- Network Drive\r\n- MSSQL\r\n- GitHub\r\n- OneDrive\r\n-
Salesforce\r\n- S3\r\n- GMail\r\n- Notion\r\n\r\nCo-authored-by:
Navarone Feekery
<[email protected]>","sha":"87e2f037786f576c6b8f40037a6362147db15145"}}]}]
BACKPORT-->

Co-authored-by: Praveen Kukreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:medium team:external
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanstory @praveen-kukreja @danajuratoni