Skip to content

Conversation

@fr4nc1sc0-r4m0n
Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n commented Oct 23, 2025

What does this PR do?

This PR aims to reduce the scope of the legacy kv/ci-shared/observability-ingest/cloud/gcp secret only for the integration-test-matrix pipeline.
This is part of the global process about removing this secret usage.

Why is it important?

It allows us to simplify the pre-command script and to limit the usage of a legacy secret which will be removed in the future.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

This pull request does not have a backport label. Could you fix it @fr4nc1sc0-r4m0n? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

pierrehilbert
pierrehilbert previously approved these changes Oct 23, 2025
@fr4nc1sc0-r4m0n
Copy link
Contributor Author

Some tests are failing but they do not appear to be related with this change

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @fr4nc1sc0-r4m0n

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n merged commit 41dd43d into elastic:main Oct 28, 2025
21 checks passed
v1v added a commit to v1v/elastic-agent that referenced this pull request Oct 29, 2025
v1v added a commit to v1v/elastic-agent that referenced this pull request Oct 29, 2025
@v1v v1v added the backport-active-all Automated backport with mergify to all the active branches label Oct 29, 2025
@github-actions
Copy link
Contributor

@Mergifyio backport 8.19 9.1 9.2

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

backport 8.19 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 29, 2025
* Reduce the scope of the legacy secrets usage only for integration-test-matrix

* Fix pipeline slug

* Add google oidc plugin in integration tests ech step

* Remove gcp auth plugin usage and fix pre exit command

* Fix typo

* Preserve ESS Credentials logic

* Use parameter expansion instead of adding more logic to reduce the complexity

(cherry picked from commit 41dd43d)
@v1v
Copy link
Member

v1v commented Oct 29, 2025

@fr4nc1sc0-r4m0n , forgot to mention that anytime we touch any CI related things, we need to backport to all the active branches - that's the default behaviour.

For such I added the backport-active-all label,

In some cases we need to be a bit picky and only backport to some branches, btut default it's always to all the active branches

mergify bot pushed a commit that referenced this pull request Oct 29, 2025
* Reduce the scope of the legacy secrets usage only for integration-test-matrix

* Fix pipeline slug

* Add google oidc plugin in integration tests ech step

* Remove gcp auth plugin usage and fix pre exit command

* Fix typo

* Preserve ESS Credentials logic

* Use parameter expansion instead of adding more logic to reduce the complexity

(cherry picked from commit 41dd43d)
mergify bot pushed a commit that referenced this pull request Oct 29, 2025
* Reduce the scope of the legacy secrets usage only for integration-test-matrix

* Fix pipeline slug

* Add google oidc plugin in integration tests ech step

* Remove gcp auth plugin usage and fix pre exit command

* Fix typo

* Preserve ESS Credentials logic

* Use parameter expansion instead of adding more logic to reduce the complexity

(cherry picked from commit 41dd43d)
fr4nc1sc0-r4m0n added a commit that referenced this pull request Oct 30, 2025
* Reduce the scope of the legacy secrets usage only for integration-test-matrix

* Fix pipeline slug

* Add google oidc plugin in integration tests ech step

* Remove gcp auth plugin usage and fix pre exit command

* Fix typo

* Preserve ESS Credentials logic

* Use parameter expansion instead of adding more logic to reduce the complexity

(cherry picked from commit 41dd43d)

Co-authored-by: Francisco Ramon <[email protected]>
fr4nc1sc0-r4m0n added a commit that referenced this pull request Oct 30, 2025
* Reduce the scope of the legacy secrets usage only for integration-test-matrix

* Fix pipeline slug

* Add google oidc plugin in integration tests ech step

* Remove gcp auth plugin usage and fix pre exit command

* Fix typo

* Preserve ESS Credentials logic

* Use parameter expansion instead of adding more logic to reduce the complexity

(cherry picked from commit 41dd43d)

Co-authored-by: Francisco Ramon <[email protected]>
mergify bot pushed a commit that referenced this pull request Oct 30, 2025
…10906)

(cherry picked from commit 0a1cf18)

# Conflicts:
#	.buildkite/hooks/pre-command
#	.buildkite/pipeline.yml
mergify bot pushed a commit that referenced this pull request Oct 30, 2025
…10906)

(cherry picked from commit 0a1cf18)

# Conflicts:
#	.buildkite/pipeline.yml
mergify bot pushed a commit that referenced this pull request Oct 30, 2025
fr4nc1sc0-r4m0n added a commit that referenced this pull request Oct 30, 2025
* Reduce the scope of the legacy secrets usage only for integration-test-matrix

* Fix pipeline slug

* Add google oidc plugin in integration tests ech step

* Remove gcp auth plugin usage and fix pre exit command

* Fix typo

* Preserve ESS Credentials logic

* Use parameter expansion instead of adding more logic to reduce the complexity

(cherry picked from commit 41dd43d)

Co-authored-by: Francisco Ramon <[email protected]>
v1v pushed a commit that referenced this pull request Oct 30, 2025
v1v pushed a commit that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches Deprecation skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants