New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCP resource provider #27

Closed

SylvainJuge opened this issue Oct 27, 2023 · 1 comment

Member

SylvainJuge commented Oct 27, 2023

Had to be split from #4 as the PR was getting too large.

Until we have a better option within contrib repo, we should probably use the implementation from https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/ to implement this short term.

An issue was created to contribute it to otel contrib repo GoogleCloudPlatform/opentelemetry-operations-java#266

Also, the current implementation is doing one HTTP call per resource attribute, which may not be what we aim for to minimize startup time.

SylvainJuge mentioned this issue

reuse contrib resource providers + add existing ones #4

Merged

SylvainJuge mentioned this issue

build: bump opentelemetryJavaagent from 1.32.0 to 2.0.0 #96

Merged

Member Author

SylvainJuge commented Mar 27, 2024

Fixed by #184 , the GCP resource attribute provider is now included in the upstream agent and we just execute it asynchronously like the AWS one.

SylvainJuge closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment