From 0370a78e7adb91041f188656dd7160df0e66c89c Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Thu, 22 Jul 2021 15:35:11 +0200 Subject: [PATCH] Fix: skip packages without data streams in coverage calculation (#443) --- internal/testrunner/coverageoutput.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/testrunner/coverageoutput.go b/internal/testrunner/coverageoutput.go index f6e4e5545..9657b697c 100644 --- a/internal/testrunner/coverageoutput.go +++ b/internal/testrunner/coverageoutput.go @@ -144,13 +144,16 @@ func collectTestCoverageDetails(packageRootPath, packageName string, testType Te } func findDataStreamsWithoutTests(packageRootPath string, testType TestType) ([]string, error) { + var noTests []string + dataStreamDir := filepath.Join(packageRootPath, "data_stream") dataStreams, err := ioutil.ReadDir(dataStreamDir) - if err != nil { + if errors.Is(err, os.ErrNotExist) { + return noTests, nil // there are packages that don't have any data streams (fleet_server, security_detection_engine) + } else if err != nil { return nil, errors.Wrap(err, "can't list data streams directory") } - var noTests []string for _, dataStream := range dataStreams { if !dataStream.IsDir() { continue