Diagnostic clean slate and initial features (#57)

- Removes existing DiagnosticSources (for now)
- Add OpenTelemetry Activity support for product calls
- Support optional disabling of Auditing for performance scenarios
- Misc type cleanup

Author: stevejgordon

src/Elastic.Transport.VirtualizedCluster/Audit/Auditor.cs

@@ -41,7 +41,7 @@ private Auditor(Components.VirtualizedCluster cluster, Components.VirtualizedClu
 
 	private bool StartedUp { get; }
 
-	public void ChangeTime(Func<DateTime, DateTime> selector)
+	public void ChangeTime(Func<DateTimeOffset, DateTimeOffset> selector)
 	{
 		_cluster ??= Cluster();
 		_clusterAsync ??= Cluster();

src/Elastic.Transport.VirtualizedCluster/Components/VirtualizedCluster.cs

@@ -68,7 +68,7 @@ public TransportResponse ClientCall(Func<RequestConfigurationDescriptor, IReques
 	public async Task<TransportResponse> ClientCallAsync(Func<RequestConfigurationDescriptor, IRequestConfiguration> requestOverrides = null) =>
 		await _asyncCall(Transport, requestOverrides).ConfigureAwait(false);
 
-	public void ChangeTime(Func<DateTime, DateTime> change) => _dateTimeProvider.ChangeTime(change);
+	public void ChangeTime(Func<DateTimeOffset, DateTimeOffset> change) => _dateTimeProvider.ChangeTime(change);
 
 	public void ClientThrows(bool throws) => _settings.ThrowExceptions(throws);
 }

src/Elastic.Transport.VirtualizedCluster/Providers/TestableDateTimeProvider.cs

@@ -9,16 +9,16 @@ namespace Elastic.Transport.VirtualizedCluster.Providers;
 /// <inheritdoc cref="DateTimeProvider"/>
 public sealed class TestableDateTimeProvider : DateTimeProvider
 {
-	private DateTime MutableNow { get; set; } = DateTime.UtcNow;
+	private DateTimeOffset MutableNow { get; set; } = DateTimeOffset.UtcNow;
 
 	/// <inheritdoc cref="DateTimeProvider.Now"/>
-	public override DateTime Now() => MutableNow;
+	public override DateTimeOffset Now() => MutableNow;
 
 	/// <summary>
 	/// Advance the time <see cref="Now"/> returns
 	/// </summary>
 	/// <param name="change">A fun that gets passed the current <see cref="Now"/> and needs to return the new value</param>
-	public void ChangeTime(Func<DateTime, DateTime> change) => MutableNow = change(MutableNow);
+	public void ChangeTime(Func<DateTimeOffset, DateTimeOffset> change) => MutableNow = change(MutableNow);
 
-	public override DateTime DeadTime(int attempts, TimeSpan? minDeadTimeout, TimeSpan? maxDeadTimeout) => throw new NotImplementedException();
+	public override DateTimeOffset DeadTime(int attempts, TimeSpan? minDeadTimeout, TimeSpan? maxDeadTimeout) => throw new NotImplementedException();
 }

src/Elastic.Transport/Components/NodePool/Node.cs

@@ -71,7 +71,7 @@ public IReadOnlyCollection<string> Features
 	public bool IsAlive { get; private set; }
 
 	/// <summary> When marked dead this reflects the date that the node has to be taken out of rotation till</summary>
-	public DateTime DeadUntil { get; private set; }
+	public DateTimeOffset DeadUntil { get; private set; }
 
 	/// <summary> The number of failed attempts trying to use this node, resets when a node is marked alive</summary>
 	public int FailedAttempts { get; private set; }
@@ -85,17 +85,16 @@ public IReadOnlyCollection<string> Features
 	/// </summary>
 	public bool HasFeature(string feature) => _features.Count == 0 || _featureSet.Contains(feature);
 
-
 	/// <summary>
-	/// Marks this node as dead and set the date (see <paramref name="untill"/>) after which we want it to come back alive
+	/// Marks this node as dead and set the date (see <paramref name="until"/>) after which we want it to come back alive
 	/// </summary>
-	/// <param name="untill">The <see cref="DateTime"/> after which this node should be considered alive again</param>
-	public void MarkDead(DateTime untill)
+	/// <param name="until">The <see cref="DateTime"/> after which this node should be considered alive again</param>
+	public void MarkDead(DateTimeOffset until)
 	{
 		FailedAttempts++;
 		IsAlive = false;
 		IsResurrected = false;
-		DeadUntil = untill;
+		DeadUntil = until;
 	}
 
 	/// <summary> Mark the node alive explicitly </summary>
@@ -104,20 +103,20 @@ public void MarkAlive()
 		FailedAttempts = 0;
 		IsAlive = true;
 		IsResurrected = false;
-		DeadUntil = default(DateTime);
+		DeadUntil = default;
 	}
 
 	/// <summary>
 	/// Use the nodes uri as root to create a <see cref="Uri"/> with <paramref name="path"/>
 	/// </summary>
-	public Uri CreatePath(string path) => new Uri(Uri, path);
+	public Uri CreatePath(string path) => new(Uri, path);
 
 	/// <summary>
 	/// Create a clone of the current node. This is used by <see cref="NodePool"/> implementations that supports reseeding the
 	/// list of nodes through <see cref="NodePool.Reseed"/>
 	/// </summary>
 	public Node Clone() =>
-		new Node(Uri, Features)
+		new(Uri, Features)
 		{
 			IsResurrected = IsResurrected,
 			Id = Id,
@@ -146,7 +145,7 @@ public bool Equals(Node other)
 	public static bool operator !=(Node left, Node right) => !(left == right);
 
 	/// <inheritdoc cref="Equals(Node)"/>
-	public static implicit operator Node(Uri uri) => new Node(uri);
+	public static implicit operator Node(Uri uri) => new(uri);
 
 	/// <inheritdoc cref="Equals(Node)"/>
 	public override bool Equals(object obj)

src/Elastic.Transport/Components/NodePool/NodePool.cs

@@ -20,10 +20,12 @@ public abstract class NodePool : IDisposable
 {
 	private bool _disposed;
 
+	internal NodePool() { }
+
 	/// <summary>
 	/// The last time that this instance was updated.
 	/// </summary>
-	public abstract DateTime LastUpdate { get; protected set; }
+	public abstract DateTimeOffset LastUpdate { get; protected set; }
 
 	/// <summary>
 	/// Returns the default maximum retries for the connection pool implementation.

src/Elastic.Transport/Components/NodePool/SingleNodePool.cs

@@ -21,7 +21,7 @@ public SingleNodePool(Uri uri, DateTimeProvider dateTimeProvider = null)
 	}
 
 	/// <inheritdoc />
-	public override DateTime LastUpdate { get; protected set; }
+	public override DateTimeOffset LastUpdate { get; protected set; }
 
 	/// <inheritdoc />
 	public override int MaxRetries => 0;

src/Elastic.Transport/Components/NodePool/StaticNodePool.cs

@@ -79,7 +79,7 @@ private void Initialize(IEnumerable<Node> nodes, DateTimeProvider dateTimeProvid
 	}
 
 	/// <inheritdoc />
-	public override DateTime LastUpdate { get; protected set; }
+	public override DateTimeOffset LastUpdate { get; protected set; }
 
 	/// <inheritdoc />
 	public override int MaxRetries => InternalNodes.Count - 1;