Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESQL] Load and Return Date Nanos Values #109987

Open
6 tasks
Tracked by #109352
not-napoleon opened this issue Jun 20, 2024 · 2 comments · May be fixed by #110205
Open
6 tasks
Tracked by #109352

[ESQL] Load and Return Date Nanos Values #109987

not-napoleon opened this issue Jun 20, 2024 · 2 comments · May be fixed by #110205
Assignees
@not-napoleon
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@not-napoleon
Copy link
Member

Description

Add a new DataType to ESQL to represent the Elasticsearch date nanos field type. The new data type would (initially, and for the scope of this ticket) not be supported by any functions, even functions which nominally support every type (like COALESCE). This ticket strictly covers correctly loading and returning the values from within ESQL.

Internally, we can use long block for this, as they are currently stored as longs and we see no reason to change that.

  • Write new CSV test data that uses date nanos
  • Write CSV tests for loading and returning date nanos
  • Create a new data type
  • Field Loader integration
  • Make sure we're correctly returning it over HTTP
  • Do we need a feature flag for this?
@not-napoleon not-napoleon mentioned this issue Jun 20, 2024
Open
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 20, 2024
@not-napoleon not-napoleon mentioned this issue Jun 20, 2024
Open
@nik9000
Copy link
Member

nik9000 commented Jun 20, 2024

  • Do we need a feature flag for this?

I know we'll need an EsqlCapability for testing, but I don't think we need a feature flag. Unless we're worried about the "half way" support for things like COALESCE.

@not-napoleon not-napoleon self-assigned this Jun 20, 2024
@not-napoleon not-napoleon linked a pull request Jun 26, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@not-napoleon not-napoleon

Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ESQL] Date nanos type not-napoleon/elasticsearch
3 participants
@nik9000 @not-napoleon @elasticsearchmachine