Skip to content

Commit 1e6783e

Browse files
authored
[Streams] Fix flaky Scout test (#236569)
## Summary Closes #236525 ## What happened? This was purely a case of unfortunate merge timing. This PR slightly changed the review modal behaviour: https://github.com/elastic/kibana/pull/235810/files This PR #235508 was based off the old behaviour where the review modal would show with "unmanaged" changes. But, there weren't any explicit merge conflicts, just test divergence. And the latter PR merged whilst still being deemed fresh enough, but minus the changes of the former.
1 parent 6ba1dae commit 1e6783e

File tree

1 file changed

+1
-4
lines changed
  • x-pack/platform/plugins/shared/streams_app/test/scout/ui/tests/data_management/data_processing

1 file changed

+1
-4
lines changed

x-pack/platform/plugins/shared/streams_app/test/scout/ui/tests/data_management/data_processing/error_handling.spec.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ import { expect } from '@kbn/scout';
99
import { test } from '../../../fixtures';
1010
import { generateLogsData } from '../../../fixtures/generators';
1111

12-
// Failing: See https://github.com/elastic/kibana/issues/236525
13-
test.describe.skip(
12+
test.describe(
1413
'Stream data processing - error handling and recovery',
1514
{ tag: ['@ess', '@svlOblt'] },
1615
() => {
@@ -48,7 +47,6 @@ test.describe.skip(
4847
});
4948

5049
await pageObjects.streams.saveStepsListChanges();
51-
await pageObjects.streams.confirmChangesInReviewModal();
5250

5351
// Should show error and stay in creating state
5452
await pageObjects.streams.expectToastVisible();
@@ -75,7 +73,6 @@ test.describe.skip(
7573
await pageObjects.streams.fillGrokPatternInput('%{WORD:attributes.method}');
7674
await pageObjects.streams.clickSaveProcessor();
7775
await pageObjects.streams.saveStepsListChanges();
78-
await pageObjects.streams.confirmChangesInReviewModal();
7976
await pageObjects.streams.closeToasts();
8077

8178
// Edit the processor

0 commit comments

Comments
 (0)