Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] JSON formatting for database spans #107751

Open
smith opened this issue Aug 5, 2021 · 10 comments
Open

[APM] JSON formatting for database spans #107751

smith opened this issue Aug 5, 2021 · 10 comments
Labels
enhancement New value added to drive a business result good first issue low hanging fruit stale Used to mark issues that were closed for being stale Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@smith
Copy link
Contributor

smith commented Aug 5, 2021

Related elastic/apm-agent-nodejs#2019

We show queries for spans with type db, but if it's not SQL it just renders this text field:

image

Figure out if we can determine if the query language is JSON, and give it pretty formatting and highlighting in these cases.

@smith smith added the Team:APM All issues that need APM UI Team support label Aug 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added [zube]: Backlog low hanging fruit DO NOT USE. Use `good first issue` instead good first issue low hanging fruit and removed low hanging fruit DO NOT USE. Use `good first issue` instead labels Aug 9, 2021
@Pranjal-dew
Copy link

Hi, is this issue still open? Care if I take it?

@sorenlouv
Copy link
Member

Hi @Pranjal-dew , yes, please take it. I'll assign it to you. Let me know if you need some help. For setting up Kibana and APM please follow: https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/readme.md#local-environment-setup

@Pranjal-dew
Copy link

Thanks, @sqren for responding. I'll get back to you if I stuck somewhere.

@matschaffer
Copy link
Contributor

Just thought I'd mention that in the case of an elasticsearch db, being able to open the query in profiler or dev tools could be a really awesome feature add. And probably make our internal work easier on any APM-enabled front (like kibana).

@sorenlouv
Copy link
Member

being able to open the query in profiler or dev tools could be a really awesome feature add.

@smith You added this functionality for inspectable queries, right?

@smith
Copy link
Contributor Author

smith commented Nov 15, 2021

@smith You added this functionality for inspectable queries, right?

Yes, but in this case it would be a bit trickier, since if you're viewing a query from elasticsearch, what is the URL of the kibana instance associated with the cluster where this query was performed? If you want to run it against the kibana you're currently running, that could work, assuming the data and indexes are the same.

I think it's an interesting feature idea, but separate from this and requiring more thought and planning.

@botelastic
Copy link

botelastic bot commented May 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label May 14, 2022
@stale stale bot removed the stale Used to mark issues that were closed for being stale label Jul 4, 2023
@smith smith added enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith smith removed the Team:APM All issues that need APM UI Team support label Jul 11, 2024
@botelastic
Copy link

botelastic bot commented Jan 7, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result good first issue low hanging fruit stale Used to mark issues that were closed for being stale Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

5 participants