Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM integration UI rum response headers field is missing validation #201448

Open
carsonip opened this issue Nov 22, 2024 · 1 comment
Open

APM integration UI rum response headers field is missing validation #201448

carsonip opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
apm bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@carsonip
Copy link
Member

carsonip commented Nov 22, 2024

Kibana version: confirmed on 8.13.4 but should apply to all versions

Elasticsearch version: 8.13.4

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.): ESS

Describe the bug:

In APM integration policy UI, the rum custom http response headers input field does not have validation. If the user enters an invalid input, it will cause apm server to fail silently due to elastic/apm-server#14560 .

There are 2 improvements needed here:

  • Instructions need to be clearer. The user does not know what should be put in this field when there is no example / clear instructions.
  • There needs to be validation. Allowing a user to input invalid config only for them to fail is bad user experience. Add a validation property to this definition.

According to apm-server.yml, response headers should be an object:

    # Custom HTTP headers to add to RUM responses, e.g. for security policy compliance.
    #response_headers:
    #  X-My-Header: Contents of the header

Steps to reproduce:

  1. start a ESS deployment
  2. Go to apm integration policy UI, input "none" to the rum response headers field
  3. restart apm integration on ESS
  4. notice that ESS apm server endpoint becomes gray

Expected behavior:
The invalid input should be called out in the UI

Screenshots (if relevant):

Image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@carsonip carsonip added the bug Fixes for quality problems that affect the customer experience label Nov 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 22, 2024
@carsonip carsonip added apm Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

4 participants