Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] JSON diff view PoC (simplified) #172118

Closed

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Nov 29, 2023

Summary

A simplified version of #171750 without some extra code that's not 100% necessary for rendering rule JSON diffs:

  • Diffs for individual fields
  • Expanders and accordions

Additionally, this version memoizes all diff calculations which makes re-rendering of each tab with diffs much faster.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 29, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4733 4779 +46

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 427.6KB 427.7KB +118.0B
discover 589.4KB 589.5KB +122.0B
kibanaReact 214.5KB 214.6KB +122.0B
securitySolution 12.9MB 13.1MB ⚠️ +242.3KB
total +242.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants