From 5a3a9ff2e72852e4c1adce0a447e83e04722451a Mon Sep 17 00:00:00 2001 From: Timothy Sullivan Date: Mon, 11 Nov 2024 13:02:02 -0700 Subject: [PATCH] Remove core properties from ShareMenuItemV2 --- .../plugins/shared/share/public/components/context/index.tsx | 4 ---- .../shared/share/public/services/share_menu_manager.tsx | 1 - src/platform/plugins/shared/share/public/types.ts | 3 +-- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/platform/plugins/shared/share/public/components/context/index.tsx b/src/platform/plugins/shared/share/public/components/context/index.tsx index 0f18a46c8e399..9d79581050495 100644 --- a/src/platform/plugins/shared/share/public/components/context/index.tsx +++ b/src/platform/plugins/shared/share/public/components/context/index.tsx @@ -7,8 +7,6 @@ * License v3.0 only", or the "Server Side Public License, v 1". */ -import { ThemeServiceSetup } from '@kbn/core-theme-browser'; -import { I18nStart } from '@kbn/core/public'; import React, { type PropsWithChildren, createContext, useContext } from 'react'; import { AnonymousAccessServiceContract } from '../../../common'; @@ -29,8 +27,6 @@ export interface IShareContext extends ShareContext { anonymousAccess?: AnonymousAccessServiceContract; urlService: BrowserUrlService; snapshotShareWarning?: string; - theme: ThemeServiceSetup; - i18n: I18nStart; publicAPIEnabled?: boolean; anchorElement?: HTMLElement; } diff --git a/src/platform/plugins/shared/share/public/services/share_menu_manager.tsx b/src/platform/plugins/shared/share/public/services/share_menu_manager.tsx index 14644d7664bfd..686bd0856ecdc 100644 --- a/src/platform/plugins/shared/share/public/services/share_menu_manager.tsx +++ b/src/platform/plugins/shared/share/public/services/share_menu_manager.tsx @@ -134,7 +134,6 @@ export class ShareMenuManager { onClose(); unmount(); }, - ...startServices, }} />, startServices diff --git a/src/platform/plugins/shared/share/public/types.ts b/src/platform/plugins/shared/share/public/types.ts index c9cb28e9660c4..4ddab41d8a08a 100644 --- a/src/platform/plugins/shared/share/public/types.ts +++ b/src/platform/plugins/shared/share/public/types.ts @@ -11,7 +11,7 @@ import type { ComponentType, ReactElement, ReactNode } from 'react'; import type { InjectedIntl } from '@kbn/i18n-react'; import { EuiContextMenuPanelDescriptor } from '@elastic/eui'; import { EuiContextMenuPanelItemDescriptorEntry } from '@elastic/eui/src/components/context_menu/context_menu'; -import type { Capabilities, ThemeServiceSetup, ToastsSetup } from '@kbn/core/public'; +import type { Capabilities, ToastsSetup } from '@kbn/core/public'; import type { UrlService, LocatorPublic } from '../common/url_service'; import type { BrowserShortUrlClientFactoryCreateParams } from './url_service/short_urls/short_url_client_factory'; import type { BrowserShortUrlClient } from './url_service/short_urls/short_url_client'; @@ -132,7 +132,6 @@ export interface ShareMenuItemV2 extends ShareMenuItemBase { * Not applicable for exports that do not call a remote API (i.e Lens CSV export) */ generateExportUrl?: (args: ScreenshotExportOpts) => string | undefined; - theme?: ThemeServiceSetup; renderLayoutOptionSwitch?: boolean; layoutOption?: 'print'; generateCopyUrl?: URL;