Reimplemented Ruby's CoercibleString setting into Java #18187
Merged
+123
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
|
andsel
force-pushed
the
feature/coercible_string_setting_to_java
branch
from
130cb84 to
dceca97
Compare
…se the functionality
donoghuc
reviewed
Jan 22, 2026
logstash-core/src/main/java/org/logstash/settings/CoercibleStringSetting.java
Outdated
Show resolved
Hide resolved
donoghuc
reviewed
Jan 22, 2026
logstash-core/src/test/java/org/logstash/settings/CoercibleStringSettingTest.java
Outdated
Show resolved
Hide resolved
donoghuc
reviewed
Jan 22, 2026
Member
donoghuc
left a comment
donoghuc
left a comment
There was a problem hiding this comment.
Couple small suggestions, otherwise looks good!
Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
💚 Build Succeeded
History
cc @andsel |
Contributor
Author
|
run exhaustive test |
Contributor
Author
|
run exhaustive tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Translates
CoercibleStringsetting class into plain Java, adding unit test to cover the functionality.Why is it important/What is the impact to the user?
N/A
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs