-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove unused gradle tasks #18526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused gradle tasks #18526
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
|
run exhaustive tests |
|
Getting the entrypoints mainly consolidated to gradle makes cleaning the unused gradle tasks quite straightforward. Going through the rake tasks will be a bit more complex as there appears to be some tasks that may be relevant to non-ci workflows. I am planning on separating out the rake task cleanup into a separate PR. |
| } | ||
| } | ||
|
|
||
| tasks.register("generatePluginsVersion") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs have been changing alot, I might be out of sync.
Does this mean we no longer use reference docs workflow? - https://github.com/elastic/logstash-docs/blob/89fac69db8de43a1fca62aa1c4c983455d5986fd/.github/workflows/reference_docs-pre90.yml#L60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donoghuc can you please check if we need to leave this generatePluginsVersion task? It looks like docs pre-v9, v9 workflows are actively using - https://github.com/elastic/logstash-docs/blob/main/.github/workflows/reference_docs90.yml#L60
I might be missing something if you are handling this in other PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good find. I totally missed that. I added it back. Luckily the rake task was not removed in #18537
mashhurs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one question about generatePluginsVersion. Otherwise the best way seems go head and fix if we face some strange behaviors.
| } | ||
| } | ||
|
|
||
| tasks.register("generatePluginsVersion") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donoghuc can you please check if we need to leave this generatePluginsVersion task? It looks like docs pre-v9, v9 workflows are actively using - https://github.com/elastic/logstash-docs/blob/main/.github/workflows/reference_docs90.yml#L60
I might be missing something if you are handling this in other PRs.
Starting point for task removal
5691426 to
f8e8b62
Compare
💚 Build Succeeded
History
|
|
@Mergifyio backport 8.19 9.1 9.2 9.3 |
✅ Backports have been createdDetails
Cherry-pick of 28c810d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 28c810d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 28c810d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 28c810d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh
* WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh
* WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh
* WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh
* Remove unused gradle tasks (#18526) * WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh * resolve merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
* Remove unused gradle tasks (#18526) * WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh * resolve merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
* Remove unused gradle tasks (#18526) * WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh * fix merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
* Remove unused gradle tasks (#18526) * WIP? Remove unused gradle tasks Starting point for task removal * add back plugin version task after code review (cherry picked from commit 28c810d) # Conflicts: # build.gradle # ci/ci_docs.sh * fix merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>

Release notes
[rn:skip]
What does this PR do?
This PR removes unused gradle tasks. It also removes a script from CI that is unused.
Closes #18476