Skip to content

Conversation

@donoghuc
Copy link
Member

@donoghuc donoghuc commented Dec 19, 2025

Release notes

[rn:skip]

What does this PR do?

This PR removes unused gradle tasks. It also removes a script from CI that is unused.

Closes #18476

@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2025

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@donoghuc
Copy link
Member Author

run exhaustive tests

@donoghuc donoghuc changed the title WIP? Remove unused gradle tasks Remove unused gradle tasks Dec 22, 2025
@donoghuc
Copy link
Member Author

This (simplified) graphic may help in reviewing this. Essentially it tries to map out where in our automation different tasks are used and the subsequent interplay between gradle and rake.
entrypoints

@donoghuc donoghuc marked this pull request as ready for review December 22, 2025 20:57
@donoghuc
Copy link
Member Author

Getting the entrypoints mainly consolidated to gradle makes cleaning the unused gradle tasks quite straightforward. Going through the rake tasks will be a bit more complex as there appears to be some tasks that may be relevant to non-ci workflows. I am planning on separating out the rake task cleanup into a separate PR.

}
}

tasks.register("generatePluginsVersion") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs have been changing alot, I might be out of sync.
Does this mean we no longer use reference docs workflow? - https://github.com/elastic/logstash-docs/blob/89fac69db8de43a1fca62aa1c4c983455d5986fd/.github/workflows/reference_docs-pre90.yml#L60

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donoghuc can you please check if we need to leave this generatePluginsVersion task? It looks like docs pre-v9, v9 workflows are actively using - https://github.com/elastic/logstash-docs/blob/main/.github/workflows/reference_docs90.yml#L60
I might be missing something if you are handling this in other PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good find. I totally missed that. I added it back. Luckily the rake task was not removed in #18537

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question about generatePluginsVersion. Otherwise the best way seems go head and fix if we face some strange behaviors.

}
}

tasks.register("generatePluginsVersion") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donoghuc can you please check if we need to leave this generatePluginsVersion task? It looks like docs pre-v9, v9 workflows are actively using - https://github.com/elastic/logstash-docs/blob/main/.github/workflows/reference_docs90.yml#L60
I might be missing something if you are handling this in other PRs.

@elasticmachine
Copy link

💚 Build Succeeded

History

@donoghuc donoghuc merged commit 28c810d into elastic:main Jan 20, 2026
12 checks passed
@donoghuc donoghuc added the backport-active-all Automated backport with mergify to all the active branches label Jan 20, 2026
@github-actions
Copy link
Contributor

@Mergifyio backport 8.19 9.1 9.2 9.3

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2026

backport 8.19 9.1 9.2 9.3

✅ Backports have been created

Details

Cherry-pick of 28c810d has failed:

On branch mergify/bp/8.19/pr-18526
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 28c810d73.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   build.gradle
	deleted by them: ci/ci_docs.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 28c810d has failed:

On branch mergify/bp/9.1/pr-18526
Your branch is up to date with 'origin/9.1'.

You are currently cherry-picking commit 28c810d7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   build.gradle
	deleted by them: ci/ci_docs.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 28c810d has failed:

On branch mergify/bp/9.2/pr-18526
Your branch is up to date with 'origin/9.2'.

You are currently cherry-picking commit 28c810d7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   build.gradle
	deleted by them: ci/ci_docs.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Cherry-pick of 28c810d has failed:

On branch mergify/bp/9.3/pr-18526
Your branch is up to date with 'origin/9.3'.

You are currently cherry-picking commit 28c810d7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   build.gradle
	deleted by them: ci/ci_docs.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Jan 20, 2026
* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh
mergify bot pushed a commit that referenced this pull request Jan 20, 2026
* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh
mergify bot pushed a commit that referenced this pull request Jan 20, 2026
* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh
mergify bot pushed a commit that referenced this pull request Jan 20, 2026
* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh
donoghuc added a commit that referenced this pull request Jan 20, 2026
* Remove unused gradle tasks (#18526)

* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh

* resolve merge conflicts

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Jan 20, 2026
* Remove unused gradle tasks (#18526)

* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh

* resolve merge conflicts

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Jan 20, 2026
* Remove unused gradle tasks (#18526)

* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh

* fix merge conflicts

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Jan 20, 2026
* Remove unused gradle tasks (#18526)

* WIP? Remove unused gradle tasks

Starting point for task removal

* add back plugin version task after code review

(cherry picked from commit 28c810d)

# Conflicts:
#	build.gradle
#	ci/ci_docs.sh

* fix merge conflicts

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused tasks in gradle/rake/make

3 participants