-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove unused/unreachable rake tasks #18537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future.
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
💚 Build Succeeded
History
|
|
run exhaustive tests |
mashhurs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| VERSION_FILE = "versions.yml" | ||
|
|
||
| def get_versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that build-fips-validation-plugin rake task wasn't used/called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it was/is used. The change that triggered this definition being moved here is the removal of the rakelib/version.rake file. This had previously been defined there. It is only needed here.
|
@Mergifyio backport 8.19 9.1 9.2 9.3 |
✅ Backports have been createdDetails
Cherry-pick of 4c15870 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 4c15870 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 4c15870 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of 4c15870 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/test.rake # rakelib/vendor.rake
* Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/plugin.rake # rakelib/test.rake # rakelib/vendor.rake
* Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/test.rake # rakelib/vendor.rake
* Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/test.rake # rakelib/vendor.rake
* Remove unused/unreachable rake tasks (#18537) * Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/test.rake # rakelib/vendor.rake * resolve merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
* Remove unused/unreachable rake tasks (#18537) * Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/plugin.rake # rakelib/test.rake # rakelib/vendor.rake * resolve merge conflicts * resolve merge conflicts pt 2 --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
* Remove unused/unreachable rake tasks (#18537) * Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/test.rake # rakelib/vendor.rake * resolve merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
* Remove unused/unreachable rake tasks (#18537) * Remove unused/unreachable rake tasks This commit removes any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future. * replace deleted function in caller's rakefile (cherry picked from commit 4c15870) # Conflicts: # rakelib/test.rake # rakelib/vendor.rake * fix merge conflicts --------- Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>

Release notes
[rn:skip]
What does this PR do?
Remove any rake task that is not called by a gradle task (or is a dependency of a rake task that is called by a gradle task). This follows up work to remove unused gradle tasks and ensure that all ci entrypoints start in gradle. The only exception are the linting tasks. These may be used in development workflows and may be usedful if we add linting steps to CI in the future.