Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obs AI Assistant supports other models than ELSER when field type semantic_text is used #4754

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Obs AI Assistant supports other models than ELSER when field type semantic_text is used #4754

merged 5 commits into from
Jan 27, 2025

Conversation

mdbirnstiehl
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl commented Jan 8, 2025 •
edited
Loading

Description

The Obs AI Assistant supports other models than ELSER when field type semantic_text is used and the docs need to be updated to show this.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4608

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@mdbirnstiehl mdbirnstiehl added backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify labels Jan 8, 2025
@mdbirnstiehl mdbirnstiehl self-assigned this Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mdbirnstiehl mdbirnstiehl marked this pull request as ready for review January 10, 2025 15:37
@mdbirnstiehl mdbirnstiehl requested a review from a team as a code owner January 10, 2025 15:37
@mdbirnstiehl mdbirnstiehl changed the title add-e5-model Obs AI Assistant supports other models than ELSER when field type semantic_text is used Jan 14, 2025
@mdbirnstiehl
Copy link
Contributor Author

@sorenlouv could you take a look here and see if I'm missing anything. Thanks!

sorenlouv
sorenlouv reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some notes on how to use semantic text fields in search connectors. I'd expect the search connector docs to also cover how to add semantic text fields.

sorenlouv
sorenlouv previously approved these changes Jan 22, 2025
View reviewed changes
colleenmcginnis
colleenmcginnis reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions below!

docs/en/observability/observability-ai-assistant.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/observability-ai-assistant.asciidoc Show resolved Hide resolved
docs/en/observability/observability-ai-assistant.asciidoc Outdated Show resolved Hide resolved
@mdbirnstiehl mdbirnstiehl merged commit da7cdce into elastic:main Jan 27, 2025
4 checks passed
@mdbirnstiehl mdbirnstiehl deleted the ai-semantic-text branch January 27, 2025 16:08
mergify bot pushed a commit that referenced this pull request Jan 27, 2025
@mdbirnstiehl @mergify
Obs AI Assistant supports other models than ELSER when field type sem…
2b39f38 
…antic_text is used (#4754)

(cherry picked from commit da7cdce)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc
@mergify mergify bot mentioned this pull request Jan 27, 2025
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request Jan 27, 2025
@mdbirnstiehl @mergify
Obs AI Assistant supports other models than ELSER when field type sem…
0e29794 
…antic_text is used (#4754)

(cherry picked from commit da7cdce)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc
@mergify mergify bot mentioned this pull request Jan 27, 2025
Merged
10 tasks
mdbirnstiehl added a commit that referenced this pull request Jan 27, 2025
@mergify @mdbirnstiehl
[8.17](backport #4754) Obs AI Assistant supports other models than EL…
8b56458 
…SER when field type semantic_text is used (#4789)

* Obs AI Assistant supports other models than ELSER when field type semantic_text is used (#4754)

(cherry picked from commit da7cdce)

Co-authored-by: Mike Birnstiehl <[email protected]>
mdbirnstiehl added a commit that referenced this pull request Jan 27, 2025
@mergify @mdbirnstiehl
[8.x](backport #4754) Obs AI Assistant supports other models than ELS…
73cac72 
…ER when field type semantic_text is used (#4788)

* Obs AI Assistant supports other models than ELSER when field type semantic_text is used (#4754)

(cherry picked from commit da7cdce)

Co-authored-by: Mike Birnstiehl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

@sorenlouv sorenlouv sorenlouv left review comments

Assignees

@mdbirnstiehl mdbirnstiehl

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: Obs AI Assistant supports other models than ELSER when field type semantic_text is used
3 participants
@mdbirnstiehl @sorenlouv @colleenmcginnis