Complete script resource migration with lint fixes and changelog update

Co-authored-by: tobio <[email protected]>

Author: Copilot

CHANGELOG.md

@@ -13,6 +13,7 @@
 - Migrate `elasticstack_kibana_action_connector` to the Terraform plugin framework ([#1269](https://github.com/elastic/terraform-provider-elasticstack/pull/1269))
 - Migrate `elasticstack_elasticsearch_security_role_mapping` resource and data source to Terraform Plugin Framework ([#1279](https://github.com/elastic/terraform-provider-elasticstack/pull/1279))
 - Add support for `inactivity_timeout` in `elasticstack_fleet_agent_policy` ([#641](https://github.com/elastic/terraform-provider-elasticstack/issues/641))
+- Migrate `elasticstack_elasticsearch_script` resource to Terraform Plugin Framework ([#1297](https://github.com/elastic/terraform-provider-elasticstack/pull/1297))
 
 ## [0.11.17] - 2025-07-21
 

internal/elasticsearch/cluster/script/acc_test.go

@@ -217,4 +217,4 @@ func checkScriptDestroy(s *terraform.State) error {
 		}
 	}
 	return nil
-}
+}

internal/elasticsearch/cluster/script/create.go

@@ -12,4 +12,4 @@ func (r *scriptResource) Create(ctx context.Context, req resource.CreateRequest,
 	if resp.Diagnostics.HasError() {
 		return
 	}
-}
+}

internal/elasticsearch/cluster/script/delete.go

@@ -30,4 +30,4 @@ func (r *scriptResource) Delete(ctx context.Context, req resource.DeleteRequest,
 
 	sdkDiags := elasticsearch.DeleteScript(ctx, client, compId.ResourceId)
 	resp.Diagnostics.Append(utils.FrameworkDiagsFromSDK(sdkDiags)...)
-}
+}

internal/elasticsearch/cluster/script/models.go

@@ -12,4 +12,4 @@ type ScriptData struct {
 	Source                  types.String `tfsdk:"source"`
 	Params                  types.String `tfsdk:"params"`
 	Context                 types.String `tfsdk:"context"`
-}
+}

internal/elasticsearch/cluster/script/read.go

@@ -50,21 +50,20 @@ func (r *scriptResource) Read(ctx context.Context, req resource.ReadRequest, res
 	data.Source = types.StringValue(script.Source)
 
 	// Handle params if returned by the API
-	if script.Params != nil && len(script.Params) > 0 {
+	if len(script.Params) > 0 {
 		paramsBytes, err := json.Marshal(script.Params)
 		if err != nil {
 			resp.Diagnostics.AddError("Error marshaling script params", err.Error())
 			return
 		}
 		data.Params = types.StringValue(string(paramsBytes))
-	} else if !data.Params.IsNull() {
-		// If params were set but API doesn't return them, preserve from state
-		// This maintains backwards compatibility
 	}
+	// Note: If params were set but API doesn't return them, they are preserved from state
+	// This maintains backwards compatibility
 
 	// Note: context is not returned by the Elasticsearch API (json:"-" in model)
 	// It's only used during script creation, so we preserve it from state
 	// This is consistent with the SDKv2 implementation
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
-}
+}

internal/elasticsearch/cluster/script/resource.go

@@ -23,4 +23,4 @@ func (r *scriptResource) Configure(_ context.Context, req resource.ConfigureRequ
 	client, diags := clients.ConvertProviderData(req.ProviderData)
 	resp.Diagnostics.Append(diags...)
 	r.client = client
-}
+}

internal/elasticsearch/cluster/script/schema.go

@@ -60,4 +60,4 @@ func GetSchema() schema.Schema {
 			},
 		},
 	}
-}
+}

internal/elasticsearch/cluster/script/update.go

@@ -72,4 +72,4 @@ func (r *scriptResource) Update(ctx context.Context, req resource.UpdateRequest,
 	if resp.Diagnostics.HasError() {
 		return
 	}
-}
+}

internal/utils/validators/string_is_json.go

@@ -32,4 +32,4 @@ func (s StringIsJSON) ValidateString(_ context.Context, req validator.StringRequ
 		)
 		return
 	}
-}
+}