Extracted from #53
Right now autocompletion and other features (like the hierarchy tree that's shown at the top of the file) doesn't work if the source isn't valid Crystal code but it's almost valid Crystal code. These cases happen because the user is typing a new, but incomplete, expression.
Some of these cases are already handled by Crystalline. For example:
Autocompletions work fine here because, I think, if the completion happens after a dot the rest of the line is cleared to allow a more successful parsing. Like this:
# No errors anymore
hello = 1
hello
In that case we could maybe transform the code to this:
Or maybe
hello = 1
hello.`the empty string`
that is, parse it to a call where the method name is empty, if the cursor happens to be right after the dot and nothing else is coming (or a newline is coming, etc.)
Here's another example:
In this case autocompletion doesn't work because the "remove everything after the dot" trick doesn't help because the code is missing an end. One idea here is to first rewrite the code to this:
hello = 1
if hello.|; end
That is, we add a ; end when appropriate to make it pass (combined with the previous fix of the "dot empty" sequence it will parse correctly.)
Some of these ideas are also expressed here: https://bugs.ruby-lang.org/issues/19013
I think this will be mostly about heuristics, finding cases that break and trying to fix them, so it's important to have tests for this to make sure we don't introduce regressions.
If it's fine with you I can start working on this. My idea is to first have a way to add the missing ends or curly braces based only on the indentation of the code. Then have a fault-tolerant parser, or a cursor-aware parser, that will produce a valid AST in case something is missing (like the first example here.)
Extracted from #53
Right now autocompletion and other features (like the hierarchy tree that's shown at the top of the file) doesn't work if the source isn't valid Crystal code but it's almost valid Crystal code. These cases happen because the user is typing a new, but incomplete, expression.
Some of these cases are already handled by Crystalline. For example:
Autocompletions work fine here because, I think, if the completion happens after a dot the rest of the line is cleared to allow a more successful parsing. Like this:
In that case we could maybe transform the code to this:
Or maybe
that is, parse it to a call where the method name is empty, if the cursor happens to be right after the dot and nothing else is coming (or a newline is coming, etc.)
Here's another example:
In this case autocompletion doesn't work because the "remove everything after the dot" trick doesn't help because the code is missing an
end. One idea here is to first rewrite the code to this:That is, we add a
; endwhen appropriate to make it pass (combined with the previous fix of the "dot empty" sequence it will parse correctly.)Some of these ideas are also expressed here: https://bugs.ruby-lang.org/issues/19013
I think this will be mostly about heuristics, finding cases that break and trying to fix them, so it's important to have tests for this to make sure we don't introduce regressions.
If it's fine with you I can start working on this. My idea is to first have a way to add the missing ends or curly braces based only on the indentation of the code. Then have a fault-tolerant parser, or a cursor-aware parser, that will produce a valid AST in case something is missing (like the first example here.)