Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getters/setters and "defineProperty" #38

Open
rozek opened this issue Jan 18, 2024 · 2 comments
Open

getters/setters and "defineProperty" #38

rozek opened this issue Jan 18, 2024 · 2 comments

Comments

@rozek
Copy link

rozek commented Jan 18, 2024

First of all: thank you very much for your brilliant library!

However, when I tried to use it, I ran into the problem that Object.defineProperty does not seem to be supported. For that reason, I tried to understand your code and made a very first attempt to add such support (see my own fork of your original).

So far, it seems to "work on my machine" but I would still consider my code as very (pre?) alpha.

Nevertheless, I would really like to see full object support in "hyperactiv".

With greetings from Germany,

Andreas Rozek

@elbywan
Copy link
Owner

elbywan commented Feb 19, 2024

Hey @rozek 👋

First of all: thank you very much for your brilliant library!

Thanks, and sorry for the late reply 🙇 !

Nevertheless, I would really like to see full object support in "hyperactiv".

I agree that this would be nice to have - if it does not inflate the bundle size (<1.5kb). Unfortunately very busy these days and I'm not sure I will be able to work on this in the near future but I'll keep this in mind when I have some free time 👍.

@rozek
Copy link
Author

rozek commented Feb 23, 2024

Hello Julien,

don't worry - we are all busy!

And since I implemented the extra functionality needed for my project myself (well, at least, I think I have) there is no urgent need for an "official" implementation.

With greetings from Germany,

Andreas Rozek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants